Reassign ownership of plugins/saved_objects away from Core team #46435

rudolf · 2019-09-24T08:54:51Z

The SavedObject class and other helpers from the savedObjects plugin in src/plugins/saved_objects/ is technical debt left over from before the NP migration and will be removed in 8.0. The following features/utilities will have to be migrated:

Before saving, checks for any existing saved object with the same type and title. If found, prompt users if they want to overwrite the existing object instead of saving a new one.
-> Move to src/plugins/kibana_react/public/saved_objects/saved_object_save_modal.tsx
if showInRecentlyAccessed is set to true, updates the recentlyAccessed menu/list
-> Use chrome.recentlyAccessed api explicitly when needed
injectReferences / extractReferences temporary compatibility helpers to help plugins migrate to references
-> Plugins should complete the migration to references by using references directly
Stop depending on savedObjects:listingLimit advanced setting. Users sometimes sets this to 10k which adversely affects Elasticsearch performance Expensive queries are causing unnecessary load and delays on Elasticsearch #93770. We need a UI pattern that scales better see [EuiPagination] add a variation with next/previous buttons only eui#4506 (will open separate issue)

Plugins that have savedObjects as a requiredPlugin or requiredBundle and require action:

The text was updated successfully, but these errors were encountered:

elasticmachine · 2019-09-24T08:54:52Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-09-24T08:54:53Z

Pinging @elastic/kibana-platform

joshdover · 2019-10-15T15:44:06Z

Moving to App Team after discussing them taking this on.

joshdover · 2019-10-15T15:45:09Z

\cc @flash1293

joshdover · 2020-01-28T23:28:24Z

@kertal just to confirm, this is still blocked by #42639?

kertal · 2020-01-29T08:15:08Z

No, due to recent changes this can be started

joshdover · 2020-02-24T19:22:49Z

@maryia-lapata Did #57452 close this issue as well?

flash1293 · 2020-02-25T08:38:53Z

@joshdover This is not completely done, we just moved the code over for now. We will continue cleaning up the implementation in the upcoming weeks.

elasticmachine · 2022-02-08T17:28:52Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

rudolf · 2022-02-14T10:12:44Z

@elastic/kibana-presentation is tracking removing their dependency on the SavedObjectsLoader here [Dashboard] [Meta] Tech Debt Roadmap #120182 "Using the saved objects client directly".
Once that is done, we can remove the tagging decorator from the saved_objects_tagging_oss plugin so that this plugin no longer depends on plugins/saved_objects.
The remaining dependencies should be limited to the SavedObjectClass and the UI components like SavedObjectSaveModal, SavedObjectFinder and misc helpers. These should either be maintained by the wider Kibana analytics team (the main consumer) or shared UX team.

rudolf · 2023-03-09T14:45:31Z

We've set a deadline for removing this plugin for 8.0 and then extended it by another year to 8.8. The important thing is that the core team is not maintaining this and our ownership of this plugin does not make sense. So instead of removing it completely we can just remove our ownership. I've asked @thomasneirynck to help us find the most suitable team to own this past 8.8.

rudolf · 2023-03-14T18:47:22Z

Related #150604

thomasneirynck · 2024-01-11T14:06:57Z

After some auditing and cleanup, it seems the dependencies are as follows

Analyticss-app no longer have plugin dependencies, but retains some static dependencies on the save_modal-UX.
there is a plugin-dependency for the class still in saved_objects_tagging_oss.

kibana/src/plugins/saved_objects_tagging_oss/public/plugin.ts

Line 30 in 3730dd0

savedObjects.registerDecorator(tagDecoratorConfig);
security_solution likely has an unused dependency here (

kibana/x-pack/plugins/security_solution/kibana.jsonc

Line 54 in 2b1cd4d

"savedObjects",

) cc @YulNaumenko This probably can be removed, but will need double checking.

wrt future ownership: it seems current dependencies are minimal, and saved_modal could probably move to a package. The actual class and decorator might be something that shared-ux or core retain until that last dependency is cleaned up.

cc @lukeelmers @rudolf @vadimkibana wdyt?

TinaHeiligers · 2024-03-26T15:47:40Z

@thomasneirynck is this issue still valid?

thomasneirynck · 2024-03-29T13:33:36Z

@TinaHeiligers yes, it still is.

YulNaumenko · 2024-04-03T03:19:11Z

After some auditing and cleanup, it seems the dependencies are as follows

Analyticss-app no longer have plugin dependencies, but retains some static dependencies on the save_modal-UX.

there is a plugin-dependency for the class still in saved_objects_tagging_oss.

kibana/src/plugins/saved_objects_tagging_oss/public/plugin.ts

Line 30 in 3730dd0

savedObjects.registerDecorator(tagDecoratorConfig);

security_solution likely has an unused dependency here (

kibana/x-pack/plugins/security_solution/kibana.jsonc

Line 54 in 2b1cd4d

"savedObjects",

) cc @YulNaumenko This probably can be removed, but will need double checking.

wrt future ownership: it seems current dependencies are minimal, and saved_modal could probably move to a package. The actual class and decorator might be something that shared-ux or core retain until that last dependency is cleaned up.

cc @lukeelmers @rudolf @vadimkibana wdyt?

It should be removed for security_solution. We used that before for Discover integration and don't need that any more. Just forgotten to cleanup.

…#180649) Related to Kibana team request to cleanup unused dependencies #46435 (comment)

## Summary Another step towards getting rid of the savedobjects plugin which was scheduled for removal since 2019 😓 #46435 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

## Summary Another step towards getting rid of the savedobjects plugin which was scheduled for removal since 2019 😓 elastic#46435 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ac29d0f) # Conflicts: # src/plugins/dashboard/public/services/saved_objects_tagging/saved_objects_tagging.stub.ts # src/plugins/dashboard/public/services/saved_objects_tagging/saved_objects_tagging_service.ts # src/plugins/dashboard/public/services/saved_objects_tagging/types.ts

rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform Team:AppArch labels Sep 24, 2019

rudolf changed the title ~~NP Migration: ui/saved_object~~ NP Migration: ui/saved_objects/saved_object Sep 24, 2019

This was referenced Sep 24, 2019

[Meta] Graph Technical Plan #44225

Closed

Graph Migration plan #45791

Closed

kertal mentioned this issue Oct 3, 2019

[Discover] Migration to New Platform #47093

Closed

46 tasks

joshdover added Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:New Platform Team:AppArch Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 15, 2019

kertal self-assigned this Nov 15, 2019

kertal mentioned this issue Dec 4, 2019

Migrate saved object to typescript and deangularisation #51562

Merged

2 tasks

joshdover mentioned this issue Jan 29, 2020

[meta] Cross-team platform migration blockers #56349

Closed

46 tasks

maryia-lapata assigned maryia-lapata and unassigned kertal Mar 9, 2020

maryia-lapata mentioned this issue Mar 11, 2020

[NP] Graph: get rid of saved objects class wrapper #59917

Merged

2 tasks

flash1293 unassigned maryia-lapata May 7, 2020

planadecu added the loe:small Small Level of Effort label Feb 8, 2022

afharo added EnableJiraSync and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc EnableJiraSync labels Feb 8, 2022

botelastic bot added the needs-team Issues missing a team label label Feb 8, 2022

afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 8, 2022

botelastic bot removed the needs-team Issues missing a team label label Feb 8, 2022

afharo added the EnableJiraSync label Feb 8, 2022

petrklapka added EnableJiraSync and removed EnableJiraSync labels Feb 8, 2022

afharo added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 8, 2022

legrego removed the EnableJiraSync label Aug 18, 2022

kertal mentioned this issue Aug 25, 2022

[Discover] Enable tags for saved searches #136162

Merged

9 tasks

rudolf assigned thomasneirynck Mar 9, 2023

rudolf changed the title ~~Remove plugins/saved_objects~~ Reassign ownership of plugins/saved_objects away from Core team Mar 9, 2023

stratoula removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 30, 2023

YulNaumenko mentioned this issue Apr 11, 2024

[Security Solution] Removed unused dependency for savedObjects plugin #180649

Merged

YulNaumenko added a commit that referenced this issue Apr 12, 2024

[Security Solution] Removed unused dependency for savedObjects plugin (…

447a730

…#180649) Related to Kibana team request to cleanup unused dependencies #46435 (comment)

rudolf mentioned this issue Sep 6, 2024

Attempt to get rid of SavedObjectClass #192265

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reassign ownership of plugins/saved_objects away from Core team #46435

Reassign ownership of plugins/saved_objects away from Core team #46435

rudolf commented Sep 24, 2019 •

edited by stratoula

Loading

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 24, 2019

joshdover commented Oct 15, 2019

joshdover commented Oct 15, 2019

joshdover commented Jan 28, 2020

kertal commented Jan 29, 2020

joshdover commented Feb 24, 2020

flash1293 commented Feb 25, 2020

elasticmachine commented Feb 8, 2022

rudolf commented Feb 14, 2022

rudolf commented Mar 9, 2023

rudolf commented Mar 14, 2023

thomasneirynck commented Jan 11, 2024 •

edited

Loading

TinaHeiligers commented Mar 26, 2024

thomasneirynck commented Mar 29, 2024

YulNaumenko commented Apr 3, 2024

Reassign ownership of plugins/saved_objects away from Core team #46435

Reassign ownership of plugins/saved_objects away from Core team #46435

Comments

rudolf commented Sep 24, 2019 • edited by stratoula Loading

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 24, 2019

joshdover commented Oct 15, 2019

joshdover commented Oct 15, 2019

joshdover commented Jan 28, 2020

kertal commented Jan 29, 2020

joshdover commented Feb 24, 2020

flash1293 commented Feb 25, 2020

elasticmachine commented Feb 8, 2022

rudolf commented Feb 14, 2022

rudolf commented Mar 9, 2023

rudolf commented Mar 14, 2023

thomasneirynck commented Jan 11, 2024 • edited Loading

TinaHeiligers commented Mar 26, 2024

thomasneirynck commented Mar 29, 2024

YulNaumenko commented Apr 3, 2024

rudolf commented Sep 24, 2019 •

edited by stratoula

Loading

thomasneirynck commented Jan 11, 2024 •

edited

Loading