[NP] Move ui/saved_objects to NP #57452

maryia-lapata · 2020-02-12T14:35:20Z

This PR contains movement of src/legacy/ui/public/saved_objects to src/plugins/saved_objects/public. All consumers were switched to the new location directly. The old unit tests were converted to Jest.

# Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/legacy_imports.ts

# Conflicts: # src/legacy/core_plugins/visualizations/public/saved_visualizations/_saved_vis.ts

elasticmachine · 2020-02-17T11:40:45Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293

Looks mostly good to me, great work! Left one comment I'm not sure about.

I know it's already like this in master, but the plugin should contain a kibana.json descriptor file on the top level. Check out the other plugins in src/plugins. I would have thought this would fail the build somehow, interesting.

src/core/MIGRATION.md

joshdover · 2020-02-19T18:39:37Z

I know it's already like this in master, but the plugin should contain a kibana.json descriptor file on the top level. Check out the other plugins in src/plugins. I would have thought this would fail the build somehow, interesting.

This is only required if the plugin is a real "runtime" plugin, not just static exports. I don't think this is necessary until we migrate the management UI into this plugin as well, but doesn't hurt to add it now. 🤷‍♂

joshdover

I know this is just a move to unblock other teams, but I am a bit concerned about the lack of test coverage, especially on the SavedObjectsLoader class. I think it's fine if we merge without additional coverage, but I'd like to see a follow-up issue/PR for getting at least some more coverage on this.

# Conflicts: # src/plugins/data/public/mocks.ts # src/plugins/data/public/ui/query_string_input/__snapshots__/query_string_input.test.tsx.snap

maryia-lapata · 2020-02-20T06:37:58Z

I know it's already like this in master, but the plugin should contain a kibana.json descriptor file on the top level. Check out the other plugins in src/plugins. I would have thought this would fail the build somehow, interesting.

This is only required if the plugin is a real "runtime" plugin, not just static exports. I don't think this is necessary until we migrate the management UI into this plugin as well, but doesn't hurt to add it now. 🤷‍♂

@flash1293 , @joshdover I added kibana.json and almost empty plugin.ts here. Please take a look.

Dosant

Code LGTM.
I am working on finishing shim for src/legacy/core_plugins/visualizations/ and this was one of the biggest dependencies there. Thanks 👍

flash1293

Changes LGTM, thanks a lot for this! This is another major blocker gone for multiple teams. I will create a follow-up issue to subsequently clean up the implementation and increase test coverage.

nreese

maps changes lgtm
code review

# Conflicts: # src/legacy/core_plugins/visualizations/public/embeddable/visualize_embeddable.ts

kibanamachine · 2020-02-20T15:08:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 19973e5

History

💔 Build #27814 failed f2858b2
💚 Build #27584 succeeded 0a11087
💔 Build #27349 failed 10d8faf
💔 Build #27253 failed 6e6e7a0
💔 Build #27154 failed 1ea3ab9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal

Code LGTM 👍

PR elastic#57452 added an empty savedObjects plugin with the same name as the core plugin. Due to the way we were spreading into our context coupled with the fact that we don't get NP's whitelisting of plugins on legacy, we were overriding the core plugin here. If this happens again, we should perhaps whitelist our plugins here.

PR #57452 added an empty savedObjects plugin with the same name as the core plugin. Due to the way we were spreading into our context coupled with the fact that we don't get NP's whitelisting of plugins on legacy, we were overriding the core plugin here. If this happens again, we should perhaps whitelist our plugins here.

…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json

* Move saved_objects to NP * Update path for imports * Remove ui/saved_objects * Update i18n IDs * Convert test * Replace Bluebird to Promise; fix unit tests * Mock openConfirm in test * Add kibana.json * Check unit test * Update unit tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

PR #57452 added an empty savedObjects plugin with the same name as the core plugin. Due to the way we were spreading into our context coupled with the fact that we don't get NP's whitelisting of plugins on legacy, we were overriding the core plugin here. If this happens again, we should perhaps whitelist our plugins here. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

maryia-lapata added 9 commits February 11, 2020 17:47

Move saved_objects to NP

cf5ff35

Merge remote-tracking branch 'kibana/master' into move-saved-objects

fd882fb

# Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/legacy_imports.ts

Update path for imports

754614b

Remove ui/saved_objects

b445571

Update i18n IDs

a8597c0

Convert test

b4ab65e

Merge remote-tracking branch 'kibana/master' into move-saved-objects

69f5171

# Conflicts: # src/legacy/core_plugins/visualizations/public/saved_visualizations/_saved_vis.ts

Replace Bluebird to Promise; fix unit tests

8f1b3eb

Mock openConfirm in test

1ea3ab9

maryia-lapata added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0 labels Feb 17, 2020

maryia-lapata changed the title ~~Move saved objects~~ [NP] Move ui/saved_objects to NP Feb 17, 2020

maryia-lapata requested a review from flash1293 February 17, 2020 12:00

ppisljar mentioned this pull request Feb 17, 2020

Visualizations plugin move to NP #50897

Closed

11 tasks

flash1293 reviewed Feb 17, 2020

View reviewed changes

src/core/MIGRATION.md Show resolved Hide resolved

maryia-lapata added 4 commits February 18, 2020 11:11

Merge branch 'master' into move-saved-objects

8a6cbfe

Add kibana.json

6e6e7a0

Check unit test

10d8faf

Update unit tests

0a11087

maryia-lapata marked this pull request as ready for review February 19, 2020 13:22

maryia-lapata requested a review from a team February 19, 2020 13:22

maryia-lapata requested review from a team as code owners February 19, 2020 13:22

joshdover approved these changes Feb 19, 2020

View reviewed changes

Merge branch 'master' into move-saved-objects

f2858b2

# Conflicts: # src/plugins/data/public/mocks.ts # src/plugins/data/public/ui/query_string_input/__snapshots__/query_string_input.test.tsx.snap

Dosant approved these changes Feb 20, 2020

View reviewed changes

flash1293 approved these changes Feb 20, 2020

View reviewed changes

nreese approved these changes Feb 20, 2020

View reviewed changes

Merge remote-tracking branch 'kibana/master' into move-saved-objects

19973e5

# Conflicts: # src/legacy/core_plugins/visualizations/public/embeddable/visualize_embeddable.ts

kertal approved these changes Feb 20, 2020

View reviewed changes

maryia-lapata merged commit 857f9f8 into elastic:master Feb 20, 2020

maryia-lapata deleted the move-saved-objects branch February 20, 2020 18:20

maryia-lapata mentioned this pull request Feb 20, 2020

[7.x] [NP] Move ui/saved_objects to NP (#57452) #58157

Merged

rylnd mentioned this pull request Feb 21, 2020

[SIEM] Prevent core savedObjects plugin from being overridden #58193

Merged

7 tasks

maryia-lapata added the backported label Feb 21, 2020

joshdover mentioned this pull request Feb 24, 2020

Reassign ownership of plugins/saved_objects away from Core team #46435

Open

20 tasks

This was referenced Feb 4, 2022

Move plugins/saved_objects ownerhip #124692

Closed

Move saved objects loader to dashboard plugin #124708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NP] Move ui/saved_objects to NP #57452

[NP] Move ui/saved_objects to NP #57452

maryia-lapata commented Feb 12, 2020 •

edited

Loading

elasticmachine commented Feb 17, 2020

flash1293 left a comment

joshdover commented Feb 19, 2020

joshdover left a comment

maryia-lapata commented Feb 20, 2020

Dosant left a comment

flash1293 left a comment

nreese left a comment

kibanamachine commented Feb 20, 2020

kertal left a comment

[NP] Move ui/saved_objects to NP #57452

[NP] Move ui/saved_objects to NP #57452

Conversation

maryia-lapata commented Feb 12, 2020 • edited Loading

elasticmachine commented Feb 17, 2020

flash1293 left a comment

Choose a reason for hiding this comment

joshdover commented Feb 19, 2020

joshdover left a comment

Choose a reason for hiding this comment

maryia-lapata commented Feb 20, 2020

Dosant left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 20, 2020

💚 Build Succeeded

History

kertal left a comment

Choose a reason for hiding this comment

maryia-lapata commented Feb 12, 2020 •

edited

Loading