-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilldown plugin #58097
Merged
Merged
Drilldown plugin #58097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:Drilldowns
Embeddable panel Drilldowns
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:AppArch
v7.7.0
v8.0.0
labels
Feb 20, 2020
Pinging @elastic/kibana-app-arch (Team:AppArch) |
mistic
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the files under Operations team code owners lgtm
mattkime
reviewed
Feb 20, 2020
mattkime
reviewed
Feb 20, 2020
x-pack/plugins/drilldowns/public/actions/open_flyout_add_drilldown/index.tsx
Outdated
Show resolved
Hide resolved
mattkime
approved these changes
Feb 20, 2020
retest |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There are no CSS changes in this PR, only removing one unused CSS class. |
streamich
added a commit
that referenced
this pull request
Feb 21, 2020
* feat: 🎸 add <PanelOptionsMenu> component * feat: 🎸 use presentational <PanelOptionsMenu> component * feat: 🎸 create stubs for Drilldown components * feat: 🎸 open new drilldown flyout from panel's context menu * feat: 🎸 setup Drilldowns plugin in X-Pack * feat: 🎸 add Storybook to drilldowns plugin * refactor: 💡 move drilldown components to x-pack * feat: 🎸 add stub action to open drilldown flyout * feat: 🎸 add drilldowns plugin to translation index * fix: 🐛 correct TypeScript type check * fix: 🐛 use correct i18n namespace * ci: 🎡 add drilldowns plugin to CODEOWNERS file * fix: 🐛 revert back <PanelOptionsMenu> change * fix: 🐛 type must not be empty
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 21, 2020
…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Drilldowns
Embeddable panel Drilldowns
release_note:skip
Skip the PR/issue when compiling release notes
review
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drilldowns
plugin in X-Pack.To see React component stubs run
Checklist
Delete any items that are not applicable to this PR.
For maintainers