Skip to content

Commit

Permalink
Prevent core savedObjects plugin from being overridden
Browse files Browse the repository at this point in the history
PR elastic#57452 added an empty savedObjects plugin with the same name as the
core plugin. Due to the way we were spreading into our context coupled
with the fact that we don't get NP's whitelisting of plugins on legacy,
we were overriding the core plugin here.

If this happens again, we should perhaps whitelist our plugins here.
  • Loading branch information
rylnd committed Feb 21, 2020
1 parent 6b77c88 commit 7fbf028
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/siem/public/app/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const SiemAppComponent: React.FC<SiemAppComponentProps> = ({ core, plugins }) =>
storage: new Storage(localStorage),
...core,
...plugins,
savedObjects: core.savedObjects,
}}
>
<StartApp {...compose(core)} />
Expand Down

0 comments on commit 7fbf028

Please sign in to comment.