Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] ML job creation fails when any sub-pattern fails to match #48219

Closed
weltenwort opened this issue Oct 15, 2019 · 3 comments · Fixed by #48231
Closed

[Logs UI] ML job creation fails when any sub-pattern fails to match #48219

weltenwort opened this issue Oct 15, 2019 · 3 comments · Fixed by #48231
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0

Comments

@weltenwort
Copy link
Member

Problem description

The ML job creation uses the index name pattern specified in the configuration of the log source the user currently views. This includes by default the filebeat-* as well as the kibana_sample_data_logs index. If either don't exist or are empty, the job setup fails.

The chances for that are pretty high for two common scenarios:

  • The user already has data in filebeat-* and just wants to enable analysis.
  • The user wants to play around with the example data without the need for ingesting data.

Proposed solution

Let the user choose a subset of index name patterns on setup to adapt to the use-case.

Acceptance criteria

  • The setup screen shows configuration options that allow for selecting of sub-patterns of the configured log index name pattern. A sub-pattern is a segment of the comma-separated index name pattern.
  • By default, if there are sub-patterns in addition to the example pattern, they are selected while the example pattern is deselected.
  • By default, if only one sub-pattern is present, it is selected and the form is disabled.
  • The user can select and de-select a sub-pattern if there are more than one.
@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Oct 15, 2019
@weltenwort weltenwort self-assigned this Oct 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui (Team:infra-logs-ui)

@afgomez
Copy link
Contributor

afgomez commented Oct 17, 2019

Regarding the acceptance, what should happen if the user selects both indices in the form but only one of them is present? Should it still fail or continue with the analysis with the existing data?

@weltenwort
Copy link
Member Author

weltenwort commented Oct 17, 2019

The creation will fail since ML requires every sub-pattern to match at least one index with at least one document. The error message will point it out. That's exactly the point of the proposed solution, to give the user the option to deselect the patterns that don't match anything.

elastic/elasticsearch#48056 aims to relax that requirement on the ML side so it hopefully will be possible to include empty indices in the datafeed config at some point.

weltenwort added a commit that referenced this issue Oct 21, 2019
This fixes #48219 by adding the option for the user to select a subset of the configured log indices during the setup process. It also surfaces the errors returned by Kibana when the setup fails.
weltenwort added a commit to weltenwort/kibana that referenced this issue Oct 21, 2019
…tic#48231)

This fixes elastic#48219 by adding the option for the user to select a subset of the configured log indices during the setup process. It also surfaces the errors returned by Kibana when the setup fails.
weltenwort added a commit to weltenwort/kibana that referenced this issue Oct 21, 2019
…tic#48231)

This fixes elastic#48219 by adding the option for the user to select a subset of the configured log indices during the setup process. It also surfaces the errors returned by Kibana when the setup fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants