[Logs UI] Provide index name pattern choice during ML job setup

[weltenwort]

Summary

This fixes #48219 by adding the option for the user to select a subset of the configured log indices during the setup process. It also surfaces the errors returned by Kibana when the setup fails.

Description

The subset is derived by splitting the configured log index name pattern on commas and presenting the in a checkbox group. That split tries to emulate what happens to the index setting in ML datafeeds upon start.

A naive validation checks that at least one sub-pattern is selected, but it doesn't check for validity of the individual patterns.

This change also required a change to the logic of how outdated job configurations are detected. Instead of an exact match, a job configuration is now considered outdated if any of the sub-patterns used during deployment is not part of the log indices set in the source configuration anymore.

The errors returned by the job setup API are now presented in error call-outs, because they give hints as to the exact pattern that caused the deployment to fail.

Previews

Checklist

• This was checked for cross-browser compatibility, including a check against IE11 could not be checked yet because kibana failed to load on IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios will be added in a follow-up PR
• This was checked for keyboard-only and screenreader accessibility

[elasticmachine]

Pinging @elastic/infra-logs-ui (Team:infra-logs-ui)

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 8cb973d1e08744051e43b29befaa613cb3ea9cb0

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 1b003d78dc7456e44b3a35e59c01432a74af3838

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 30a1255c055f655917b0f5b504a9bc6ea54d5e36

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 16b595cc5f694fe5094da1ce51b753b1dacab874

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: f3aa009

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c553f97

[afgomez]

A nitpicky comment: should we prevent the form from submitting if the user hasn't selected any indices?

[afgomez]

Nice work! I did add some comments on small details I found on a first pass. I also found a small nitpicky detail when playing with the UI (see comment above), but overall looks good.

Please confirm if the comments I proposed make sense. Otherwise I can approve straight away

[weltenwort]

Thanks for the quick review. That all makes a lot of sense - I'll tackle it next thing in the morning 👍

[jasonrhodes]

@weltenwort just wanted to say that the screenshots here look really good, I'm super happy with this "best we can do" solution to this onboarding problem.

[sgrodzicki]

I just wanted to comment on that as I was struggling with setting up ML jobs with sample data only as filebeat-* indices were missing and this change solved the problem for me. Great job @weltenwort!

Before:

After:

[weltenwort]

@afgomez I made some changes based on your feedback:

• The spelling for "analyze" is now consistent with American English.
• The validation logic is simpler.
• The (re)creation button is now disabled if the form is not deemed valid.
• The file structure of the setup section now matches the import direction (downwards).
• The ValidationError type is shared between UI components, but not with the container. The reasoning is that they represent the provider and the consumer side, the types of which must be compatible, but are not "the same". One declares that it provides and the other declares what it consumes.

Let me know what you think.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 605a0fc

[afgomez]

@weltenwort thanks!

The ValidationError type is shared between UI components, but not with the container.

Makes sense. If for whatever reason this hurts in the future (i.e. we need to add more error types and we see too much duplication) we can find a different way.

I'll approve

[weltenwort]

@elasticmachine update branch

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 3253526

[Kerry350]

(LGTM 👌)