Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CSP usage collector to New Platform #50511

Closed
joshdover opened this issue Nov 13, 2019 · 7 comments · Fixed by #75536
Closed

Migrate CSP usage collector to New Platform #50511

joshdover opened this issue Nov 13, 2019 · 7 comments · Fixed by #75536
Assignees
@pgayvallet
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

We have a usage collector used for telemetry on CSP usage that was moved into the legacy kibana plugin in #45769. This is not a kibana-app concern and should probably live in either Core or into the OSS telemetry plugin. This is blocking the kibana-app from migrating to the new platform.

We should probably ensure that the schema of telemetry doesn't change so there's no break in data before and after the move.

In terms of where to put this, the usage collector pattern is planned to move to a plugin (#46924), so this may need to live in a plugin as well.

Thoughts @Bamieh?

cc @flash1293 @rudolf
@joshdover joshdover added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry Team:Stack Services labels Nov 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@joshdover
Copy link
Contributor Author

We're going to move forward with moving this into the usage_collector plugin itself and consume the CSP data from Core. In the future, this should probably live in Core itself once Pulse is merged into Core.

@joshdover joshdover removed the blocker label Jan 14, 2020
@Bamieh
Copy link
Member

Bamieh commented Jan 14, 2020

@joshdover can we move it into the telemetry plugin under src/legacy/core_plugins/telemetry/server/collectors/csp? the usageCollection plugin does not have any collectors registered and i really think it should stay this way to not add any more complexity to telemetry.

@joshdover
Copy link
Contributor Author

joshdover commented Jan 14, 2020 via email

@joshdover joshdover mentioned this issue Jul 31, 2020
Closed
14 tasks
@pgayvallet
Copy link
Contributor

@joshdover @afharo

From #71927 (comment), I guess this should now be moved to the kibana_usage_collection plugin, right?

@pgayvallet pgayvallet self-assigned this Aug 20, 2020
@pgayvallet pgayvallet mentioned this issue Aug 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate CSP usage collector to kibana_usage_collection plugin pgayvallet/kibana
6 participants
@pgayvallet @lukeelmers @joshdover @bmcconaghy @Bamieh @elasticmachine