Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved searches on dashboard do not move to top when advancing to next page #7012

Closed
djschny opened this issue Apr 21, 2016 · 3 comments
Closed

Saved searches on dashboard do not move to top when advancing to next page #7012

djschny opened this issue Apr 21, 2016 · 3 comments
Labels
Feature:Discover Discover Application good first issue low hanging fruit release_note:enhancement still valid? Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@djschny
Copy link
Contributor

djschny commented Apr 21, 2016

Steps to reproduce:

  1. Create a saved search with a good amount of data
  2. Create a dashboard and add that saved search to the dashboard
  3. Mouse over the saved search in the dashboard and scroll down to the bottom
  4. Click page 2 to advance to the next page
  5. Observe that you are advanced to the next page but you need to manually scroll back up to the top to see the "next row" which is the logical/natural pattern people would do while interacting with that kind of pane.
@rashidkpc
Copy link
Contributor

Agreed this is annoying.

@tbragin tbragin added :Discovery Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Dashboard Dashboard related features and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 9, 2016
@epixa epixa removed the P2 label Apr 25, 2017
@stacey-gammon stacey-gammon added the Feature:Discover Discover Application label May 31, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 14, 2018
@lukasolson lukasolson added the good first issue low hanging fruit label Oct 10, 2018
@sainthkh
Copy link
Contributor

As a newbie of this project, I tried to implement this feature. But I found that it cannot be done at this moment. Because there are so many things going on. We need to wait for them. So, I'm writing this for future reference.

Currently, Kibana is migrating from angular to react. And the component we should fix to solve this problem is legacy DocTable component written in Angular. Specifically, this annoying data table panel works with react panel and react button groups with angular DocTable.

Therefore, to implement this feature now, we need to trigger Angular scroll to top action from react button.

In addition, EUI team is trying to create datagrid component that'll replace many of the tables in Discover.

So, things written for Angular should be removed eventually. It's not worthy of hard work now. We need to wait for future changes.

@timroes timroes added still valid? and removed Feature:Dashboard Dashboard related features labels Oct 7, 2020
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member

kertal commented Jun 28, 2022

tested and it works, so it's no longer valid. when moving to the next page, Document explorer starts from top

@kertal kertal closed this as completed Jun 28, 2022
jbudz pushed a commit that referenced this issue Aug 14, 2023
@1Copenut @tkajtoch
@cee-chen @drewdaemon
Upgrade EUI to v86.0.0 (#163088)
83d9644 
`85.1.0` ➡️ `86.0.0`

⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd`
dependency to it's open-source forked successor, `@hello-pangea/dnd`.
This new fork has better typescript support and additionally supports
both React 17 and React 18.

## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0)

- Added React 18 support (StrictMode not yet supported).
([#7012](elastic/eui#7012))

**Deprecations**

- Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary`
instead. ([#6992](elastic/eui#6992))

**Breaking changes**

- Replaced the underlying drag-and-drop library from
`react-beautiful-dnd` to its fork `@hello-pangea/dnd`
([#7012](elastic/eui#7012))
([#7012](elastic/eui#7012))
- No code updates are needed if using only `<EuiDragDropContext>`,
`<EuiDroppable>` and `<EuiDraggable>` with no direct imports from
`react-beautiful-dnd`. In case you were importing things from
`react-beautiful-dnd` and using them together with EUI components, you
need to switch to `@hello-pangea/dnd` which has cross-compatible API.

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Drew Tate <andrew.tate@elastic.co>
bryce-b pushed a commit that referenced this issue Aug 22, 2023
@1Copenut @tkajtoch
@cee-chen @drewdaemon @bryce-b
Upgrade EUI to v86.0.0 (#163088)
3e052f2 
`85.1.0` ➡️ `86.0.0`

⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd`
dependency to it's open-source forked successor, `@hello-pangea/dnd`.
This new fork has better typescript support and additionally supports
both React 17 and React 18.

## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0)

- Added React 18 support (StrictMode not yet supported).
([#7012](elastic/eui#7012))

**Deprecations**

- Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary`
instead. ([#6992](elastic/eui#6992))

**Breaking changes**

- Replaced the underlying drag-and-drop library from
`react-beautiful-dnd` to its fork `@hello-pangea/dnd`
([#7012](elastic/eui#7012))
([#7012](elastic/eui#7012))
- No code updates are needed if using only `<EuiDragDropContext>`,
`<EuiDroppable>` and `<EuiDraggable>` with no direct imports from
`react-beautiful-dnd`. In case you were importing things from
`react-beautiful-dnd` and using them together with EUI components, you
need to switch to `@hello-pangea/dnd` which has cross-compatible API.

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Drew Tate <andrew.tate@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application good first issue low hanging fruit release_note:enhancement still valid? Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@epixa @djschny @kertal @timroes @tbragin @lukasolson @rashidkpc @sainthkh @stacey-gammon