Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v86.0.0 #163088

Merged
merged 41 commits into from
Aug 14, 2023
Merged

Upgrade EUI to v86.0.0 #163088

merged 41 commits into from
Aug 14, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Aug 3, 2023

85.1.0 ➡️ 86.0.0

⚠️ The biggest change in this PR is migrating the react-beautiful-dnd dependency to it's open-source forked successor, @hello-pangea/dnd. This new fork has better typescript support and additionally supports both React 17 and React 18.

86.0.0

  • Added React 18 support (StrictMode not yet supported). (#7012)

Deprecations

  • Deprecated euiPaletteComplimentary; Use euiPaletteComplementary instead. (#6992)

Breaking changes

  • Replaced the underlying drag-and-drop library from react-beautiful-dnd to its fork @hello-pangea/dnd (#7012) (#7012)
    • No code updates are needed if using only <EuiDragDropContext>, <EuiDroppable> and <EuiDraggable> with no direct imports from react-beautiful-dnd. In case you were importing things from react-beautiful-dnd and using them together with EUI components, you need to switch to @hello-pangea/dnd which has cross-compatible API.

@1Copenut 1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting labels Aug 3, 2023
@1Copenut 1Copenut self-assigned this Aug 3, 2023
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@cee-chen
Copy link
Contributor

⚠️ 8.10 FF

As a heads up to all codeowners pinged in this PR, we will be aiming to merge this PR by 8.10 FF. We will be asking KibanaOps for an admin merge by EOD Monday.

While we're relatively confident that the React 18 support in this PR primarily affected types and should not have affected any production-facing UI/UX, we'd certainly appreciate a quick smoke test on your end to confirm that's the case. Please feel free to ping us ASAP if you do find any issues stemming from EUI/this release.

Thanks all!

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot change lgtm

@1Copenut 1Copenut requested a review from jbudz August 14, 2023 12:51
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review, tested in chrome

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules Management LGTM

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I opened a PR with a few suggestions.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discoverLogExplorer 315 313 -2
enterpriseSearch 2200 2201 +1
fileUpload 217 219 +2
infra 1393 1391 -2
logsShared 198 196 -2
maps 992 994 +2
total -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 51.4KB 51.5KB +6.0B
aiops 568.8KB 568.8KB +6.0B
alerting 65.1KB 65.1KB +3.0B
apm 3.7MB 3.7MB +26.0B
canvas 1020.3KB 1020.3KB +3.0B
cloudDataMigration 3.6KB 3.6KB +3.0B
console 416.6KB 416.7KB +3.0B
controls 197.2KB 197.2KB +3.0B
crossClusterReplication 168.8KB 168.9KB +6.0B
dashboard 360.4KB 360.4KB +6.0B
dataViewFieldEditor 173.6KB 173.6KB +3.0B
dataViewManagement 120.3KB 120.3KB +6.0B
dataVisualizer 605.0KB 605.0KB +3.0B
devTools 5.5KB 5.5KB +3.0B
discoverLogExplorer 223.2KB 221.1KB -2.2KB
enterpriseSearch 2.6MB 2.6MB +174.0B
eventAnnotation 176.7KB 176.7KB +6.0B
exploratoryView 200.7KB 200.7KB +3.0B
expressionLegacyMetricVis 11.9KB 11.9KB +3.0B
expressionMetricVis 4.6KB 4.6KB +3.0B
expressionPartitionVis 32.1KB 32.1KB +3.0B
filesManagement 89.7KB 89.7KB +3.0B
fileUpload 957.5KB 958.1KB +629.0B
graph 407.8KB 407.8KB +3.0B
grokdebugger 8.9KB 8.9KB +3.0B
home 163.9KB 163.9KB +3.0B
imageEmbeddable 50.3KB 50.3KB +3.0B
indexLifecycleManagement 158.5KB 158.5KB +3.0B
indexManagement 522.2KB 522.2KB +6.0B
infra 2.0MB 2.0MB -725.0B
ingestPipelines 360.3KB 360.3KB +19.0B
inputControlVis 49.9KB 49.9KB +9.0B
kibanaOverview 43.9KB 43.9KB +3.0B
kubernetesSecurity 38.6KB 38.6KB +3.0B
lens 1.4MB 1.4MB +12.0B
licenseManagement 65.9KB 65.9KB +3.0B
lists 144.9KB 144.9KB +3.0B
logstash 31.1KB 31.2KB +3.0B
management 42.4KB 42.4KB +3.0B
maps 2.8MB 2.8MB +628.0B
ml 3.5MB 3.5MB +3.0B
monitoring 462.3KB 462.3KB +3.0B
observability 1.0MB 1.0MB +18.0B
observabilityOnboarding 290.3KB 290.3KB +6.0B
profiling 321.6KB 321.6KB +3.0B
remoteClusters 94.0KB 94.0KB +3.0B
rollup 134.0KB 134.0KB +6.0B
savedObjectsFinder 5.0KB 5.0KB +3.0B
searchprofiler 159.0KB 159.0KB +3.0B
securitySolution 15.6MB 15.6MB +1.4KB
sessionView 392.0KB 392.0KB +3.0B
share 5.5KB 5.5KB +3.0B
snapshotRestore 260.3KB 260.3KB +3.0B
stackAlerts 77.2KB 77.2KB +12.0B
synthetics 909.6KB 909.6KB +9.0B
telemetryManagementSection 10.5KB 10.6KB +6.0B
transform 404.7KB 404.7KB +6.0B
upgradeAssistant 156.2KB 156.2KB +3.0B
uptime 501.5KB 501.5KB +6.0B
ux 166.0KB 166.0KB +3.0B
visTypeTimeseries 511.7KB 511.7KB +15.0B
visTypeVega 1.8MB 1.8MB +359.0B
visTypeVislib 339.7KB 339.7KB +3.0B
visualizations 263.5KB 263.5KB +3.0B
watcher 163.9KB 163.9KB +3.0B
total +635.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 15.9KB 15.9KB +3.0B
advancedSettings 10.3KB 10.3KB +3.0B
alerting 34.1KB 34.1KB +3.0B
apm 36.9KB 36.9KB +3.0B
bfetch 6.9KB 6.9KB +3.0B
canvas 13.4KB 13.4KB +3.0B
cases 151.6KB 151.6KB +6.0B
charts 44.9KB 44.9KB +6.0B
cloud 5.4KB 5.4KB +3.0B
cloudChat 5.3KB 5.3KB +3.0B
cloudChatProvider 2.0KB 2.0KB +3.0B
cloudDataMigration 4.4KB 4.4KB +3.0B
cloudDefend 8.8KB 8.8KB +6.0B
cloudExperiments 6.9KB 6.9KB +3.0B
cloudFullStory 3.5KB 3.5KB +3.0B
cloudGainsight 3.5KB 3.5KB +3.0B
cloudLinks 8.9KB 8.9KB +3.0B
cloudSecurityPosture 13.0KB 13.1KB +6.0B
console 26.7KB 26.7KB +3.0B
contentManagement 7.5KB 7.5KB +3.0B
controls 37.5KB 37.5KB +3.0B
core 378.4KB 378.5KB +4.0B
customIntegrations 10.2KB 10.3KB +3.0B
dashboard 42.4KB 42.4KB +3.0B
dashboardEnhanced 15.2KB 15.2KB +6.0B
data 404.4KB 404.4KB +6.0B
dataViewEditor 12.7KB 12.7KB +6.0B
dataViewFieldEditor 25.2KB 25.2KB +6.0B
dataViews 45.3KB 45.3KB +3.0B
dataVisualizer 23.1KB 23.1KB +3.0B
devTools 11.1KB 11.1KB +3.0B
discover 31.5KB 31.5KB +6.0B
discoverEnhanced 5.9KB 5.9KB +3.0B
discoverLogExplorer 5.9KB 5.9KB +3.0B
embeddable 64.7KB 64.7KB +6.0B
embeddableEnhanced 6.7KB 6.7KB +3.0B
enterpriseSearch 38.7KB 38.8KB +3.0B
esUiShared 156.4KB 156.4KB +6.0B
eventAnnotation 21.4KB 21.4KB +3.0B
exploratoryView 44.2KB 44.2KB +6.0B
expressionError 5.2KB 5.2KB +3.0B
expressionGauge 14.5KB 14.5KB +3.0B
expressionHeatmap 14.7KB 14.7KB +3.0B
expressionRepeatImage 6.2KB 6.2KB +3.0B
expressionRevealImage 6.2KB 6.2KB +3.0B
expressions 98.0KB 98.0KB +6.0B
expressionShape 20.8KB 20.8KB +3.0B
expressionTagcloud 9.9KB 9.9KB +3.0B
expressionXY 38.0KB 38.0KB +3.0B
features 3.6KB 3.6KB +3.0B
fieldFormats 63.2KB 63.2KB +3.0B
files 10.6KB 10.6KB +3.0B
fileUpload 7.3KB 7.3KB +3.0B
fleet 138.8KB 138.8KB +6.0B
globalSearch 6.3KB 6.3KB +3.0B
globalSearchBar 26.3KB 26.3KB +3.0B
graph 7.9KB 7.9KB +3.0B
guidedOnboarding 27.7KB 27.7KB +3.0B
home 11.1KB 11.1KB +3.0B
imageEmbeddable 8.9KB 8.9KB +3.0B
indexLifecycleManagement 27.0KB 27.0KB +3.0B
indexManagement 32.5KB 32.5KB +3.0B
infra 105.9KB 105.9KB +3.0B
ingestPipelines 13.9KB 13.9KB +3.0B
inputControlVis 5.6KB 5.6KB +3.0B
inspector 21.7KB 21.7KB +3.0B
interactiveSetup 61.3KB 61.3KB +3.0B
kbnUiSharedDeps-npmDll 6.0MB 6.1MB +145.5KB
kbnUiSharedDeps-srcJs 2.2MB 2.2MB +2.0B
kibanaReact 54.3KB 54.3KB +6.0B
kibanaUtils 73.6KB 73.6KB +6.0B
lens 36.3KB 36.3KB +6.0B
licenseManagement 10.9KB 10.9KB +3.0B
licensing 9.1KB 9.1KB +3.0B
lists 3.8KB 3.8KB +3.0B
logsShared 220.4KB 219.3KB -1.1KB
logstash 14.0KB 14.0KB +3.0B
management 10.6KB 10.6KB +3.0B
maps 45.3KB 45.3KB +6.0B
mapsEms 5.7KB 5.7KB +3.0B
ml 74.4KB 74.4KB +3.0B
monitoring 24.2KB 24.2KB +6.0B
navigation 9.8KB 9.8KB +6.0B
newsfeed 10.8KB 10.8KB +6.0B
observability 59.2KB 59.3KB +3.0B
observabilityAIAssistant 18.1KB 18.1KB +6.0B
observabilityShared 43.5KB 43.5KB +6.0B
osquery 51.6KB 51.6KB +6.0B
presentationUtil 36.0KB 36.0KB +6.0B
profiling 21.9KB 21.9KB +3.0B
remoteClusters 8.5KB 8.5KB +3.0B
reporting 43.1KB 43.1KB +6.0B
savedObjects 22.3KB 22.3KB +3.0B
savedObjectsFinder 3.3KB 3.3KB +3.0B
savedObjectsManagement 19.4KB 19.4KB +6.0B
savedObjectsTagging 19.2KB 19.2KB +6.0B
savedObjectsTaggingOss 2.4KB 2.4KB +3.0B
savedSearch 10.9KB 10.9KB +3.0B
screenshotMode 2.0KB 2.0KB +3.0B
searchprofiler 19.8KB 19.8KB +3.0B
security 70.0KB 70.0KB +6.0B
securitySolutionServerless 25.4KB 25.4KB +6.0B
serverless 5.4KB 5.4KB +6.0B
serverlessObservability 44.0KB 44.0KB +3.0B
serverlessSearch 29.9KB 29.9KB +6.0B
sessionView 8.1KB 8.1KB +3.0B
share 52.0KB 52.0KB +3.0B
snapshotRestore 27.5KB 27.5KB +3.0B
spaces 26.0KB 26.0KB +6.0B
stackConnectors 35.2KB 35.2KB +3.0B
telemetry 19.2KB 19.2KB +6.0B
telemetryManagementSection 3.9KB 3.9KB +3.0B
textBasedLanguages 5.0KB 5.0KB +3.0B
threatIntelligence 27.3KB 27.3KB +3.0B
timelines 57.3KB 57.3KB +6.0B
triggersActionsUi 89.0KB 89.0KB +6.0B
uiActions 20.1KB 20.1KB +3.0B
uiActionsEnhanced 16.8KB 16.8KB +6.0B
unifiedHistogram 6.1KB 6.1KB +3.0B
unifiedSearch 34.7KB 34.7KB +6.0B
upgradeAssistant 20.1KB 20.2KB +3.0B
uptime 22.4KB 22.4KB +3.0B
urlDrilldown 15.5KB 15.5KB +3.0B
urlForwarding 2.6KB 2.6KB +3.0B
usageCollection 5.0KB 5.0KB +3.0B
visDefaultEditor 21.2KB 21.2KB +3.0B
visTypeGauge 10.8KB 10.8KB +6.0B
visTypeHeatmap 10.8KB 10.9KB +6.0B
visTypeMarkdown 7.0KB 7.0KB +6.0B
visTypeMetric 10.5KB 10.5KB +3.0B
visTypePie 8.4KB 8.4KB +6.0B
visTypeTable 16.7KB 16.7KB +3.0B
visTypeTagcloud 6.5KB 6.5KB +6.0B
visTypeTimelion 10.7KB 10.7KB +3.0B
visTypeTimeseries 18.5KB 18.5KB +3.0B
visTypeVega 33.8KB 33.8KB +3.0B
visTypeVislib 12.6KB 12.6KB +3.0B
visTypeXy 28.5KB 28.5KB +6.0B
visualizations 56.8KB 56.8KB +3.0B
watcher 13.5KB 13.5KB +3.0B
total +144.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

@jbudz jbudz merged commit 83d9644 into elastic:main Aug 14, 2023
@1Copenut 1Copenut deleted the eui/v86.0.0 branch August 14, 2023 20:47
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
`85.1.0` ➡️ `86.0.0`

⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd`
dependency to it's open-source forked successor, `@hello-pangea/dnd`.
This new fork has better typescript support and additionally supports
both React 17 and React 18.

## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0)

- Added React 18 support (StrictMode not yet supported).
([#7012](elastic/eui#7012))

**Deprecations**

- Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary`
instead. ([#6992](elastic/eui#6992))

**Breaking changes**

- Replaced the underlying drag-and-drop library from
`react-beautiful-dnd` to its fork `@hello-pangea/dnd`
([#7012](elastic/eui#7012))
([#7012](elastic/eui#7012))
- No code updates are needed if using only `<EuiDragDropContext>`,
`<EuiDroppable>` and `<EuiDraggable>` with no direct imports from
`react-beautiful-dnd`. In case you were importing things from
`react-beautiful-dnd` and using them together with EUI components, you
need to switch to `@hello-pangea/dnd` which has cross-compatible API.

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Drew Tate <andrew.tate@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.