-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta issue: [APM] Service overview: Introduce time-series comparison #81147
Comments
Pinging @elastic/apm-ui (Team:apm) |
Updated the issue description to describe the final decision on the comparison intervals. We'll be making two options available; yesterday and a week ago. Read more in the description. |
As part of the time offsets we'll need to do basic date math to present the times as if they are overlapping: this is something that should be shared, not exclusive to APM. Can it be put in a shared place in Kibana code? We already have one implementation of this logic in Timelion, and we need it as part of an upcoming esaggs feature that is intended for use in Lens. |
Looks like a decision was made to not have comparisons for date ranges longer than 7 days. I'm not necessarily against it but interested to hear the reasoning behind this. |
@sqren The reasoning was primarily trying to scope the comparison feature to an essentials-only feature in order to get this in along-side the Service overview. We have a bit more time now, and I don't see any technical reasoning for not allowing 7+ day comparison other than we need to reconsider our option labels. "A week ago" loses its clarity when you've selected a range longer than 7 days. We can consider relabelling this to "previous period" but it's less defined. |
This jogged my memory a bit, I think I misunderstood the details of the description of the different scenarios. We should not disable comparison even beyond 7 days, but we will disable (set to |
Data fetching strategy We're going to have one single API that returns the normal data and the comparison data. To reduce the complexity of the Pull Request, a few are going to be open that handles each part of what is described above. We are going to refactor some apis in order to make the comparison available: PR: #88946
PR:
APIs that must be changed adding comparison request:
|
Summary
Related design issue elastic/apm#300
The service overview introduces a new view for the selected service that encompasses a lot of the service data from existing views like metrics, transactions, and errors. The primary goal of the view is to aid in troubleshooting a service from a birds eye view rather than immediately diving into the Transactions, as that's the current landing page for a selected service. There's more information about the user stories and goals of the view in the design issue linked above.
Please note: I've marked this as a research ticket because there's still a few outstanding decisions to make on what range we're implementing as a comparison.
Time-series comparison
The general idea of the time-series comparison is to provide the user with more background on the currently selected time range. It's typically part of the analysis to investigate how the service was behaving a week ago or similar to give an indication of whether something has been slowly increasing or it's a sudden spike.
We want to make it simple for our users to select a time range and immediately have a comparison on the charts as a visual aid. This means adding an option next to the existing time range selection that allows the user to turn on/off a comparison time-series plot on all the relevant time-series charts.
Comparison options: Yesterday, a week ago, and previous period.
The UI will contain a dropdown with the options "Yesterday" and "A week ago" (wording might change).
This dropdown is only applicable when the selected time range is less than 24 hours. The dropdown will be set to
readOnly
when the time range is above 24 hours. See below for details:Time range is between 0 - 24 hours
Time range is between 24 hours - 1 week
readOnly
Time range is > 1 week
readOnly
We should add the comparison range to the URL params of the URL so it's easy for users to share a specific time and comparison for team members.
Visualizing the comparison range
The currently selected time range will be visualized the palette color matching the metric. The comparison period will feature as an area chart behind it with a grey fill and stroke. The comparison is also a thinner stroke than the current range.
The text was updated successfully, but these errors were encountered: