Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Split All instances API adding a new API to return comparison statistics #94767

Merged
merged 14 commits into from
Mar 26, 2021
Merged

[APM] Split All instances API adding a new API to return comparison statistics #94767

merged 14 commits into from
Mar 26, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Mar 16, 2021 •
edited
Loading

closes #90577

Screen Shot 2021-03-22 at 16 00 48

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 apm:comparison labels Mar 16, 2021
@cauemarcondes cauemarcondes force-pushed the apm-time-comparison-instances branch from 1b964fb to 6524826 Compare March 17, 2021 13:39
@cauemarcondes cauemarcondes force-pushed the apm-time-comparison-instances branch from 7fd25a9 to 65086fe Compare March 22, 2021 19:41
@cauemarcondes cauemarcondes marked this pull request as ready for review March 22, 2021 20:10
@cauemarcondes cauemarcondes requested a review from a team as a code owner March 22, 2021 20:10
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte
ogupte reviewed Mar 23, 2021
View reviewed changes
...ns/apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx
return (
<>
{/* <EuiFlexItem grow={3}>
<InstancesLatencyDistributionChart
height={chartHeight}
items={data}
items={data.items}
status={status}
/>
</EuiFlexItem> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget to remove this commented code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is still commented out on Master https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx#L75

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment at the top of the file: https://github.com/elastic/kibana/pull/94767/files#diff-c0ef7ba5123324610da97ba1e6b7dac3d4ed715fbdde415ae2d2cc2b07d0e060R21-R26

.../apm/public/components/app/service_overview/service_overview_instances_table/get_columns.tsx Outdated Show resolved Hide resolved
.../server/lib/services/get_service_instances/get_service_instances_system_metric_statistics.ts
max: end,
},
},
aggs: { avg: { avg: agg } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary, but i usually like to name aggs something descriptive, like comparisonAvg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a generic function I'd rather leaving the way it is now. Otherwise, I'll have to check if the field exists before using it.

...pm/server/lib/services/get_service_instances/get_service_instances_transaction_statistics.ts
(response.aggregations?.[SERVICE_NODE_NAME].buckets.map(
(serviceNodeBucket) => {
const { doc_count: count, key } = serviceNodeBucket;
const serviceNodeName = String(key);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't key always be a string? why is the cast needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, key can be string | number

smith
smith reviewed Mar 23, 2021
View reviewed changes
...ns/apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx
@@ -24,25 +30,78 @@ interface ServiceOverviewInstancesChartAndTableProps {
serviceName: string;
}

const INITIAL_STATE = {
items: [] as Array<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something from ApiReturnType here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, since the type is changed from number | null | undefined to number here https://github.com/cauemarcondes/kibana/blob/apm-time-comparison-instances/x-pack/plugins/apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx#L123-L127

@cauemarcondes cauemarcondes requested a review from smith March 25, 2021 15:19
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1757 1758 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.0MB 5.0MB +6.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 33b81b1 into elastic:master Mar 26, 2021
@cauemarcondes cauemarcondes deleted the apm-time-comparison-instances branch March 26, 2021 13:14
@cauemarcondes cauemarcondes mentioned this pull request Mar 26, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Mar 26, 2021
@cauemarcondes
[APM] Split All instances API adding a new API to return comparison s…
908e2a7 
…tatistics (elastic#94767)

* adding comparison to instances table

* fixing tests

* adding api tests

* removing unnecessary files

* fixing ts issue

* fixing ts issue

* refactoring

* refactoring

* refactoring

* refactoring

* refactoring

* addressing PR comments

* addressing PR comments
cauemarcondes added a commit that referenced this pull request Mar 26, 2021
@cauemarcondes
[APM] Split All instances API adding a new API to return comparison s…
810b7c8 
…tatistics (#94767) (#95522)

* adding comparison to instances table

* fixing tests

* adding api tests

* removing unnecessary files

* fixing ts issue

* fixing ts issue

* refactoring

* refactoring

* refactoring

* refactoring

* refactoring

* addressing PR comments

* addressing PR comments
@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Closed
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@smith smith smith approved these changes

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Split All instances API adding a new API to return comparison statistics
5 participants
@cauemarcondes @elasticmachine @kibanamachine @smith @ogupte