Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison feature #91439

Merged
merged 9 commits into from
Mar 16, 2021
Merged

[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison feature #91439

merged 9 commits into from
Mar 16, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Feb 15, 2021 •
edited
Loading

closes #90626

Adds telemetry to the time comparison feature.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 apm:comparison labels Feb 15, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 15, 2021 19:35
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just had one question

@sorenlouv
Copy link
Member

One more question: will we still fetch comparison data after this PR (I guess yes). I don't want to complicate things but would be optimal if we don't retrieve the comparison data since it's never used.

@cauemarcondes
Copy link
Contributor Author

One more question: will we still fetch comparison data after this PR (I guess yes). I don't want to complicate things but would be optimal if we don't retrieve the comparison data since it's never used.

@sqren this is not the PR the removes the time comparison on all pages, it only removes from service inventory, transactions overview and transaction details, it is still available on service overview. I'm going to work on another PR to entirely disable it for 7.12.

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes cauemarcondes requested a review from formgeist March 11, 2021 16:17
@cauemarcondes
Copy link
Contributor Author

@formgeist I'd like to double check with you what I did:

  • Track when the time comparison is manually changed by the user (Day/Week).
  • Track when a user disables the time comparison by clicking on the checkbox. (It won't track when the user enables it back, do you want to track it?)

@formgeist
Copy link
Contributor

@formgeist I'd like to double check with you what I did:

  • Track when the time comparison is manually changed by the user (Day/Week).
  • Track when a user disables the time comparison by clicking on the checkbox. (It won't track when the user enables it back, do you want to track it?)

@cauemarcondes Yup, those two interactions are critical to understanding if users tend to turn off comparisons more often and if users switch the default comparison periods.

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB +287.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit f90a4d9 into elastic:master Mar 16, 2021
@cauemarcondes cauemarcondes deleted the apm-comparison-telemetry branch March 16, 2021 15:41
@cauemarcondes cauemarcondes mentioned this pull request Mar 16, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Mar 16, 2021
@cauemarcondes @kibanamachine
[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison …
f168e12 
…feature (elastic#91439)

* adding telemetry and removing time comparison

* adding telemetry and removing time comparison

* adding telemetry

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Mar 16, 2021
@cauemarcondes @kibanamachine
[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison …
61d66c1 
…feature (#91439) (#94715)

* adding telemetry and removing time comparison

* adding telemetry and removing time comparison

* adding telemetry

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Closed
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@formgeist formgeist Awaiting requested review from formgeist

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison feature
6 participants
@cauemarcondes @elasticmachine @sorenlouv @formgeist @kibanamachine @ogupte