Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management app shows the sections that are not allowed by the current user capabilities #90770

Closed
azasypkin opened this issue Feb 9, 2021 · 5 comments · Fixed by #90782 or #92694
Closed
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@azasypkin
Copy link
Member

Kibana version: 7.10.0+

Describe the bug:

While investigating flaky tests in #90576 we noticed that sometimes Management app displays sections that it shouldn't and full page refresh fixes that.

Steps to reproduce:

  1. Prepare two users: user A (with superuser role) and user B (with kibana_admin role).
  2. Log in as user A and navigate to the Stack Management, and observe Ingest section
  3. Log out and re-login as user B (without refreshing the page)
  4. Navigate to the Stack Management and observe Ingest section. It shouldn't be shown, check the latest /capabilities response in the Dev Tools and make sure that all "apps" are set to false for ingest.
  5. Refresh the page, Ingest section is no longer displayed.

Screenshots (if relevant): (Kibana 7.11 in Cloud)

Peek 2021-02-09 13-56

Any additional context:

It's not immediately clear where the issue is exactly, but I'd like to make sure that Management app correctly analyzes user capabilities first. I noticed that you check capabilities in start, but it may become a problem in the future when we eliminate full page refresh on login/logout steps.

cc @pheyos @jportner

@azasypkin azasypkin added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@azasypkin
Copy link
Member Author

I noticed that you check capabilities in start, but it may become a problem in the future when we eliminate full page refresh on login/logout steps.

Correction, @legrego pointed out that it's known limitation and only needs to be handled once we have a solution for #59377.

@Dosant
Copy link
Contributor

Dosant commented Feb 15, 2021

It looks like there are a couple of other recent failures that look very similar to the ones described in this issue:
#91330
#91305
#91262

I wonder if #90782 didn't fully address the race condition.

I'll reopen this, but feel free to close in case I read new failures wrong

@Dosant Dosant reopened this Feb 15, 2021
@cuff-links
Copy link
Contributor

cuff-links commented Feb 17, 2021

I also believe there are several more related ones:
#91028
#91442
#91331

@legrego
Copy link
Member

legrego commented Feb 22, 2021

What changed recently to introduce all of this flakiness? This was solid when first introduced in 7.10 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
5 participants