Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency for display of management items #92694

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Improve consistency for display of management items #92694

merged 4 commits into from
Mar 2, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Feb 24, 2021 •
edited
Loading

Summary

Addresses a number of test failures that result from the incorrect registering/handling of management sections.

Resolves #91330
Resolves #91305
Resolves #91262
Resolves #91028
Resolves #91442
Resolves #91331
Resolves #92965
Resolves #92588 (Flaky test runner)
Resolves #93162
Resolves #90770 (again)

legrego
legrego commented Feb 25, 2021
View reviewed changes
x-pack/plugins/beats_management/public/bootstrap.tsx
Comment on lines +21 to +27
const startServices = await core.getStartServices();

if (startServices[0].http.anonymousPaths.isAnonymous(window.location.pathname)) {
return;
}
// Can't run until the `start` lifecycle, so we wait for start services to resolve above before calling this.
await libs.framework.waitUntilFrameworkReady();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this isn't strictly related to the resolved issues, but I noticed that Beats was making requests which required authentication on the login page (and other unauthenticated pages). This change prevents Beats from completing its initialization if we are on one such page. Moving from an unauthenticated page to an authenticated page requires a full page reload, so there is no risk to the actual stack management application.

@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes v7.11.2 v7.12.0 v7.13.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 25, 2021
@legrego legrego marked this pull request as ready for review February 25, 2021 14:51
@legrego legrego requested a review from a team as a code owner February 25, 2021 14:51
@legrego
Copy link
Member Author

legrego commented Feb 25, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Mar 1, 2021

@elasticmachine merge upstream

@legrego legrego mentioned this pull request Mar 1, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB
watcher 887.2KB 887.2KB +1.0B
total -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
beatsManagement 128.4KB 128.4KB +76.0B
crossClusterReplication 26.9KB 27.1KB +279.0B
triggersActionsUi 104.0KB 104.1KB +82.0B
watcher 24.2KB 24.9KB +721.0B
total +1.1KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga
sebelga approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those changes @legrego !

@legrego legrego merged commit 5cc480a into elastic:master Mar 2, 2021
@legrego legrego deleted the chore/management-consistency branch March 2, 2021 14:54
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@legrego @kibanamachine
Improve consistency for display of management items (elastic#92694)
11b38dc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@legrego @kibanamachine
Improve consistency for display of management items (elastic#92694)
fc6931d 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@legrego @kibanamachine
Improve consistency for display of management items (elastic#92694)
d6c0f75 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.11 / #93237
✅ 7.12 / #93238
✅ 7.x / #93239

Successful backport PRs will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
0a85947 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana:
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150)
  Cleanup Security plugin imports (elastic#93056)
  [Security Solution] - Bug fixes (elastic#92294)
  Updated doc links (elastic#92968)
  [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @legrego
Improve consistency for display of management items (#92694) (#93237)
7b9b093 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @legrego
Improve consistency for display of management items (#92694) (#93238)
395f0f5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @legrego
Improve consistency for display of management items (#92694) (#93239)
30062ec 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
88098e3 
* master: (199 commits)
  Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969)
  [Bazel] More resilient Workspace Status (elastic#93244)
  [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001)
  [Workplace Search] Role Mappings to Kibana (elastic#93123)
  [Fleet] Use type-only imports where possible (elastic#92979)
  [Lens] Set pie chart slices sorted clockwise (elastic#92617)
  Remove ms label from CPU load on status page (elastic#92836)
  [App Search] Migrate Create Meta Engine View (elastic#92127)
  [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917)
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  ...
This was referenced Mar 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.11.2 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Background Search UI (Enabled WIP Feature).x-pack/test/send_search_to_background_integration/tests/apps/management/search_sessions/sessions_management_permissions·ts - search sessions management Search sessions Management UI permissions Sessions management is available if one of apps enables search sessions Sessions management is available if one of apps enables search sessions Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_lifecycle_management/feature_controls/ilm_security·ts - Index Lifecycle Management app feature controls security global dashboard all with manage_ilm should render the "Data" section with ILM Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/upgrade_assistant/feature_controls/upgrade_assistant_security·ts - Upgrade checkup feature controls security global dashboard all with global_upgrade_assistant_role [SkipCloud] global dashboard all with global_upgrade_assistant_role should render the "Stack" section with Upgrde Assistant Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ingest_pipelines/feature_controls/ingest_pipelines_security·ts - Ingest pipelines app feature controls security global all privileges (aka kibana_admin) should not render the "Ingest" section Management app shows the sections that are not allowed by the current user capabilities
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/remote_clusters/feature_controls/remote_clusters_security·ts - Remote Clusters app feature controls security global dashboard all with license_management_user should render the "Data" section with Remote Clusters Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/cross_cluster_replication/feature_controls/ccr_security·ts - Cross Cluster Replication app feature controls security global dashboard read with ccr_user should render the "Data" section with CCR Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/license_management/feature_controls/license_management_security·ts - License app feature controls security global dashboard read with license_management_user [SkipCloud] global dashboard with license management user: skip cloud should render the "Stack" section with License Management Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/remote_clusters/feature_controls/remote_clusters_security·ts - Remote Clusters app feature controls security global dashboard read with license_management_user should render the "Data" section with Remote Clusters Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/api_keys/feature_controls/api_keys_security·ts - API Keys app feature controls security global dashboard read with manage_security should render the "Security" section with API Keys
3 participants
@legrego @kibanamachine @sebelga