Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ms label from CPU load on status page #92836

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Remove ms label from CPU load on status page #92836

merged 2 commits into from
Mar 2, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Feb 25, 2021 •
edited
Loading

Summary

Before
image

After
image

@joshdover joshdover added release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0 labels Feb 25, 2021
@joshdover joshdover marked this pull request as ready for review February 25, 2021 16:19
@joshdover joshdover requested a review from a team as a code owner February 25, 2021 16:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

With Green CI

TinaHeiligers
TinaHeiligers reviewed Feb 25, 2021
View reviewed changes
src/core/public/core_app/status/lib/load_status.ts
@@ -57,7 +57,7 @@ function formatMetrics({ metrics }: StatusResponse): Metric[] {
defaultMessage: 'Load',
}),
value: [metrics.os.load['1m'], metrics.os.load['5m'], metrics.os.load['15m']],
type: 'time',
type: 'float',
Copy link
Contributor

@TinaHeiligers TinaHeiligers Feb 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdover The time type was being formatted with a special case. I'm not sure if that's not being read properly or got lost somewhere along the line of platform migration and moving routes around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's the underlying reason this was happening. Probably something I broke a while back to be honest. I didn't remove it since we're still using this for the response_times metrics.

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@joshdover joshdover enabled auto-merge (squash) March 2, 2021 14:25
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 479.8KB 479.8KB +1.0B
triggersActionsUi 104.0KB 104.1KB +82.0B
total +83.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 9fd28b6 into elastic:master Mar 2, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@joshdover @kibanamachine
Remove ms label from CPU load on status page (elastic#92836)
c0a4266 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #93255

Successful backport PRs will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
88098e3 
* master: (199 commits)
  Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969)
  [Bazel] More resilient Workspace Status (elastic#93244)
  [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001)
  [Workplace Search] Role Mappings to Kibana (elastic#93123)
  [Fleet] Use type-only imports where possible (elastic#92979)
  [Lens] Set pie chart slices sorted clockwise (elastic#92617)
  Remove ms label from CPU load on status page (elastic#92836)
  [App Search] Migrate Create Meta Engine View (elastic#92127)
  [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917)
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  ...
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @joshdover
Remove ms label from CPU load on status page (#92836) (#93255)
f038f01 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers left review comments

@Bamieh Bamieh Bamieh approved these changes

@afharo afharo afharo approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joshdover @elasticmachine @kibanamachine @tylersmalley @afharo @Bamieh @TinaHeiligers