[Security Solution] Case ui enhancement #91863

angorayc · 2021-02-18T15:42:27Z

Summary

#91843

Hide the status for case collections
Add status all to filter list and default to that.
Update status is only available for individual cases.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…-fix

elasticmachine · 2021-02-24T13:14:45Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-02-24T13:14:45Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

angorayc · 2021-02-24T13:15:18Z

@elasticmachine merge upstream

jonathan-buttner · 2021-03-01T22:28:13Z

x-pack/plugins/case/common/api/cases/status.ts

@@ -21,6 +23,11 @@ export const CaseStatusRt = rt.union([

 export const caseStatuses = Object.values(CaseStatuses);

+export const CaseStatusFilterRt = rt.union([rt.literal(AllCaseType), ...CaseStatusRt.types]);


Do you think there's a way we could avoid adding all to the status types? If we add it here that means a case could potentially have a status of type all which wouldn't really make sense 🤔

Would it be easy to have the API call from the front end just not include any status in the query parameters? On the backend we'll automatically get all of them.

@angorayc I agree with @jonathan-buttner . It will nice if we can avoid it.

I see how you meant. I have CaseStatusRt that doesn't include all for cases, and use CaseStatusFilterRt just for rendering the filter relevant stuff.
I also remove the status from api call if the filter is set to all. Hope this makes it a bit clearer.

@angorayc As we discuss I removed the CaseStatusFilterRt.

…-fix

cnasikas

LGTM! Perfect job!

kibanamachine · 2021-03-02T14:13:52Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2204	2205	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	+1.4KB
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB
total			-22.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💔 Build #110248 failed b250898
💔 Build #110228 failed f4624bc
💔 Build #110236 failed 173dac0
💛 Build #109998 was flaky 94da327
💔 Build #109981 failed 067b20e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)

* master: (199 commits) Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969) [Bazel] More resilient Workspace Status (elastic#93244) [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001) [Workplace Search] Role Mappings to Kibana (elastic#93123) [Fleet] Use type-only imports where possible (elastic#92979) [Lens] Set pie chart slices sorted clockwise (elastic#92617) Remove ms label from CPU load on status page (elastic#92836) [App Search] Migrate Create Meta Engine View (elastic#92127) [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917) [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) ...

* ui enhancement * fix actions * unit test * update row actions * add case status all * update find status * fix type * remove all case count from dropdown * fix type error * fix unit test * disable bulk actions on status all * clean up * fix types * fix cypress tests * review * review * update status is only available for individual cases * update available actions on status all * fix unit test * remove lodash get * rename status all * omit status if it is set to all * do not sent status if itis set to all * Remove all status from the backend * Hide actions on all status * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/containers/api.ts

* ui enhancement * fix actions * unit test * update row actions * add case status all * update find status * fix type * remove all case count from dropdown * fix type error * fix unit test * disable bulk actions on status all * clean up * fix types * fix cypress tests * review * review * update status is only available for individual cases * update available actions on status all * fix unit test * remove lodash get * rename status all * omit status if it is set to all * do not sent status if itis set to all * Remove all status from the backend * Hide actions on all status * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/all_cases/actions.tsx # x-pack/plugins/security_solution/public/cases/components/all_cases/index.test.tsx # x-pack/plugins/security_solution/public/cases/components/bulk_actions/index.tsx # x-pack/plugins/security_solution/public/cases/components/status/config.ts

* ui enhancement * fix actions * unit test * update row actions * add case status all * update find status * fix type * remove all case count from dropdown * fix type error * fix unit test * disable bulk actions on status all * clean up * fix types * fix cypress tests * review * review * update status is only available for individual cases * update available actions on status all * fix unit test * remove lodash get * rename status all * omit status if it is set to all * do not sent status if itis set to all * Remove all status from the backend * Hide actions on all status * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/containers/api.ts

* [Security Solution] Case ui enhancement (#91863) * ui enhancement * fix actions * unit test * update row actions * add case status all * update find status * fix type * remove all case count from dropdown * fix type error * fix unit test * disable bulk actions on status all * clean up * fix types * fix cypress tests * review * review * update status is only available for individual cases * update available actions on status all * fix unit test * remove lodash get * rename status all * omit status if it is set to all * do not sent status if itis set to all * Remove all status from the backend * Hide actions on all status * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/all_cases/actions.tsx # x-pack/plugins/security_solution/public/cases/components/all_cases/index.test.tsx # x-pack/plugins/security_solution/public/cases/components/bulk_actions/index.tsx # x-pack/plugins/security_solution/public/cases/components/status/config.ts * fix unit tests * fix cypress test

angorayc added 17 commits February 18, 2021 22:38

ui enhancement

4803fcf

Merge branch 'master' of github.com:elastic/kibana into case-ui-fix

c1acfba

fix actions

fab3950

unit test

9b80fa9

update row actions

6dc3ca6

add case status all

5e8dcc3

update find status

46335f0

fix type

baef996

remove all case count from dropdown

0ed83b3

fix type error

0bddbf9

fix unit test

d7107bd

disable bulk actions on status all

e0c29b7

clean up

5342462

Merge branch 'case-ui-fix' of github.com:angorayc/kibana into case-ui…

f412d15

…-fix

fix types

b9da2f9

fix cypress tests

8e0251e

Merge branch 'case-ui-fix' of github.com:angorayc/kibana into case-ui…

08e3516

…-fix

angorayc marked this pull request as ready for review February 24, 2021 12:59

angorayc requested review from a team as code owners February 24, 2021 12:59

angorayc added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v8.0.0 labels Feb 24, 2021

angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Feb 24, 2021

Merge branch 'master' into case-ui-fix

6986423

cnasikas mentioned this pull request Feb 26, 2021

[Security Solution][Case] Fix subcases bugs on detections and case view #91836

Merged

20 tasks

angorayc added 2 commits March 2, 2021 00:37

update available actions on status all

067b20e

fix unit test

94da327

angorayc mentioned this pull request Mar 1, 2021

[Security Solution][Case] Subcases bugs #91843

Closed

30 tasks

jonathan-buttner reviewed Mar 1, 2021

View reviewed changes

angorayc and others added 8 commits March 2, 2021 15:23

remove lodash get

e1c285f

rename status all

c1508ba

omit status if it is set to all

a453269

do not sent status if itis set to all

a812a98

Merge branch 'master' of github.com:elastic/kibana into case-ui-fix

f4624bc

Merge branch 'master' of github.com:elastic/kibana into case-ui-fix

d05c171

Remove all status from the backend

89be6cf

Merge branch 'case-ui-fix' of github.com:angorayc/kibana into case-ui…

173dac0

…-fix

cnasikas force-pushed the case-ui-fix branch from ab3b2f2 to 173dac0 Compare March 2, 2021 09:51

cnasikas added 2 commits March 2, 2021 12:34

Merge branch 'case-ui-fix' of github.com:angorayc/kibana into case-ui…

a6c372c

…-fix

Hide actions on all status

b250898

cnasikas force-pushed the case-ui-fix branch from 173dac0 to b250898 Compare March 2, 2021 10:36

Merge branch 'case-ui-fix' of github.com:angorayc/kibana into case-ui…

92a57fd

…-fix

cnasikas approved these changes Mar 2, 2021

View reviewed changes

fix unit test

efdaf6e

angorayc enabled auto-merge (squash) March 2, 2021 13:34

angorayc merged commit 356d460 into elastic:master Mar 2, 2021

angorayc mentioned this pull request Mar 3, 2021

[7.x] [Security Solution] Case ui enhancement (#91863) #93387

Merged

angorayc mentioned this pull request Mar 3, 2021

[7.12] [Security Solution] Case ui enhancement (#91863) #93395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Case ui enhancement #91863

[Security Solution] Case ui enhancement #91863

angorayc commented Feb 18, 2021 •

edited

Loading

elasticmachine commented Feb 24, 2021

elasticmachine commented Feb 24, 2021

angorayc commented Feb 24, 2021

jonathan-buttner Mar 1, 2021 •

edited

Loading

cnasikas Mar 2, 2021

angorayc Mar 2, 2021

cnasikas Mar 2, 2021

cnasikas left a comment

kibanamachine commented Mar 2, 2021

async chunk count

		@@ -21,6 +23,11 @@ export const CaseStatusRt = rt.union([

		export const caseStatuses = Object.values(CaseStatuses);

		export const CaseStatusFilterRt = rt.union([rt.literal(AllCaseType), ...CaseStatusRt.types]);

[Security Solution] Case ui enhancement #91863

[Security Solution] Case ui enhancement #91863

Conversation

angorayc commented Feb 18, 2021 • edited Loading

Summary

Checklist

elasticmachine commented Feb 24, 2021

elasticmachine commented Feb 24, 2021

angorayc commented Feb 24, 2021

jonathan-buttner Mar 1, 2021 • edited Loading

Choose a reason for hiding this comment

cnasikas Mar 2, 2021

Choose a reason for hiding this comment

angorayc Mar 2, 2021

Choose a reason for hiding this comment

cnasikas Mar 2, 2021

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

angorayc commented Feb 18, 2021 •

edited

Loading

jonathan-buttner Mar 1, 2021 •

edited

Loading