[Security Solution] - Bug fixes #92294

michaelolo24 · 2021-02-22T21:58:19Z

Summary

This PR fixes the following bugs:

New Right Side Opening of Host and Network Details on Timeline UI broken on Safari Browser 13.1.2 #92004

[Security Solution] Fields [Integration, Configuration Status, and Sensor version] are not displayed in the host details panel without navigates to host tab. #91998

[Security Solution] [UX bug] Event/Alert Details View not wide enough on Table view/JSON view #92465

Also, did some cleanup and updated the quotation for the empty resolver message as it was incorrect before since the search bar doesn't accept single quotes for values.

elasticmachine · 2021-02-22T22:10:18Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-02-22T22:10:18Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

michaelolo24 · 2021-02-22T22:12:48Z

x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx

-    const expandedDetail = useDeepEqualSelector((state) => {
-      return (getTimeline(state, timelineId) ?? timelineDefaults).expandedDetail;
-    });
+export const DetailsPanel = ({


The only change in this file was removing React.memo. It may be causing an issue where the event_details view isn't switching properly. The props to this component do not change when the expanded_detail changes, and as this is just a wrapper of memoized components, it's unnecessary.

michaelolo24 · 2021-02-22T22:13:54Z

x-pack/plugins/security_solution/public/timelines/components/side_panel/host_details/index.tsx

+  flex: 1 0 auto;
+`;
+
+const StyledPanelContent = styled.div`


This fixes (same in network_details): #92004 (comment)

michaelolo24 · 2021-02-22T22:14:11Z

.../security_solution/public/timelines/components/side_panel/event_details/expandable_event.tsx

@@ -51,7 +51,7 @@ interface ExpandableEventTitleProps {
 }

 const StyledEuiFlexGroup = styled(EuiFlexGroup)`
-  flex: 0;
+  flex: 0 1 auto;


This fixes: #92004 (comment)

michaelolo24 · 2021-02-22T22:15:04Z

x-pack/plugins/security_solution/public/resolver/view/resolver_no_process_events.tsx

@@ -49,7 +49,7 @@ export const ResolverNoProcessEvents = () => (
    </EuiText>
    <EuiSpacer size="m" />
    <StyledEuiCodeBlock language="html" paddingSize="s" isCopyable>
-      {"event.category: 'process'"}
+      {'event.category: "process"'}


There wasn't a bug filed for this yet, but when copying the text into the search bar it doesn't work unless you use double quotes.

michaelolo24 · 2021-02-22T22:16:14Z

...ugins/security_solution/public/overview/components/host_overview/endpoint_overview/index.tsx

@@ -20,79 +20,73 @@ import * as i18n from './translations';
 interface Props {
  contextID?: string;
  data: EndpointFields | null;
-  isInDetailsSidePanel?: boolean;


These changes were just about removing isInDetailsSidePanel. It isn't necessary for these components to be aware of this

michaelolo24 · 2021-03-01T15:16:12Z

@elasticmachine merge upstream

kibanamachine · 2021-03-01T17:16:25Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	-12.0B
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB
total			-23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💛 Build #109533 was flaky b5ea5e5
💛 Build #109395 was flaky 23bc30b47148d1392a9ed5697a82eede21b0c44c
💔 Build #108773 failed 72f463f335ff70e9dee4fa0e7bdb7f4940f8988e
💔 Build #108605 failed 3969b3b4b499ab488b2b91218bbc6698d683c668

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jonathan-buttner

I pulled this down and tested that the different panel titles didn't overlap and that the indices were populated 👍

jonathan-buttner · 2021-03-01T20:05:38Z

...ns/security_solution/public/timelines/components/side_panel/host_details/expandable_host.tsx

@@ -54,10 +56,25 @@ export const ExpandableHostDetails = ({
  hostName,
 }: ExpandableHostProps & { contextID: string }) => {
  const { to, from, isInitializing } = useGlobalTime();
-  const { docValueFields, selectedPatterns } = useSourcererScope();
+  const { docValueFields } = useSourcererScope();
+  /*


Great comment 👍

kqualters-elastic

visually verified locally lgtm 👍

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

michaelolo24 requested a review from a team as a code owner February 22, 2021 21:58

michaelolo24 force-pushed the bug-fixes branch from 43ca64e to 3969b3b Compare February 22, 2021 22:08

michaelolo24 requested a review from a team February 22, 2021 22:10

michaelolo24 commented Feb 22, 2021

View reviewed changes

michaelolo24 force-pushed the bug-fixes branch 2 times, most recently from 72f463f to 23bc30b Compare February 25, 2021 14:00

michaelolo24 added 3 commits February 25, 2021 13:29

safari fix, event details fix, copyable fix

645d909

update expandableHost indices

b90c86c

increase flyout size for event details

b5ea5e5

michaelolo24 force-pushed the bug-fixes branch from 23bc30b to b5ea5e5 Compare February 25, 2021 18:32

Merge branch 'master' into bug-fixes

243c99f

jonathan-buttner approved these changes Mar 1, 2021

View reviewed changes

kqualters-elastic approved these changes Mar 2, 2021

View reviewed changes

michaelolo24 merged commit 3c4a3b8 into elastic:master Mar 2, 2021

michaelolo24 deleted the bug-fixes branch March 2, 2021 13:37

michaelolo24 mentioned this pull request Mar 2, 2021

[7.x] [Security Solution] - Bug fixes (#92294) #93208

Merged

michaelolo24 mentioned this pull request Mar 2, 2021

[7.12] [Security Solution] - Bug fixes (#92294) #93209

Merged

michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Mar 2, 2021

[Security Solution] - Bug fixes (elastic#92294)

530d788

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Mar 2, 2021

[Security Solution] - Bug fixes (elastic#92294)

7249494

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] - Bug fixes #92294

[Security Solution] - Bug fixes #92294

michaelolo24 commented Feb 22, 2021 •

edited

Loading

elasticmachine commented Feb 22, 2021

elasticmachine commented Feb 22, 2021

michaelolo24 Feb 22, 2021

michaelolo24 Feb 22, 2021

michaelolo24 Feb 22, 2021

michaelolo24 Feb 22, 2021

michaelolo24 Feb 22, 2021

michaelolo24 commented Mar 1, 2021

kibanamachine commented Mar 1, 2021

async chunk count

jonathan-buttner left a comment

jonathan-buttner Mar 1, 2021

kqualters-elastic left a comment

[Security Solution] - Bug fixes #92294

[Security Solution] - Bug fixes #92294

Conversation

michaelolo24 commented Feb 22, 2021 • edited Loading

Summary

elasticmachine commented Feb 22, 2021

elasticmachine commented Feb 22, 2021

michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

michaelolo24 commented Mar 1, 2021

kibanamachine commented Mar 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

jonathan-buttner left a comment

Choose a reason for hiding this comment

jonathan-buttner Mar 1, 2021

Choose a reason for hiding this comment

kqualters-elastic left a comment

Choose a reason for hiding this comment

michaelolo24 commented Feb 22, 2021 •

edited

Loading