Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transform functional tests - stabilize feature controls test #90772

Closed

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Feb 9, 2021

Summary

This PR stabilizes the Transform feature controls tests by adding a browser refresh before fetching menu items.

Details

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Feb 9, 2021

Checking test stability in a flaky test runner job ... the flaky test runner is currently not working correctly. Will start another run and update this comment as soon as it's working again.

@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Feb 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin
Copy link
Member

@pheyos I think we can close this one since @legrego fixed that in the BM/LP apps themselves in #90782

@pheyos
Copy link
Member Author

pheyos commented Feb 11, 2021

@pheyos I think we can close this one since @legrego fixed that in the BM/LP apps themselves in #90782

@azasypkin yes, thanks for the heads-up.

@pheyos
Copy link
Member Author

pheyos commented Feb 11, 2021

Fixed in #90782, so this workaround is no longer needed.

@pheyos pheyos closed this Feb 11, 2021
@pheyos pheyos deleted the stabilize_tfm_feature_controls_test branch February 11, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants