[RAC] T-Grid is moving to a new home #100265

XavierM · 2021-05-18T14:29:44Z

Summary

In the effort to have one alerts table to be shared between solutions, we extracted the t-grid out of the timelines. Security solutions is using a feature flag to not have any weird behavior in the mean time that we are adding functionality to it or replacing it by EuiDataGrid in the near future.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…id-new-home

…rs on @kbn/i18n

…npm-from-kbn-i18n

…c/kibana into t-grid-new-home

…id-new-home

kibanamachine · 2021-05-25T04:02:40Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: dc7ac7c
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…-home

mdefazio

No changes to UX or UI for this one as it's just about moving the component. No edits to scss files found.

spalger

Jest config tweaks/operations related changes LGTM

…id-new-home

kibanamachine · 2021-06-22T22:56:31Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1534	1535	+1
`securitySolution`	2188	2195	+7
`timelines`	19	215	+196
total			+204

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`securitySolution`	32	1130	+1098
`timelines`	6	758	+752
total			+1850

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`securitySolution`	0	8	+8
`timelines`	0	6	+6
total			+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+9.9KB
`securitySolution`	6.9MB	6.5MB	-487.5KB
`timelines`	1.3KB	426.0KB	⚠️ +424.8KB
total			-52.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`securitySolution`	6	27	+21
`timelines`	1	22	+21
total			+42

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-elastic`	2.6MB	2.6MB	+8.2KB
`kbnUiSharedDeps-js`	6.4MB	6.4MB	-6.3KB
`securitySolution`	61.6KB	197.8KB	+136.2KB
`timelines`	13.3KB	210.0KB	⚠️ +196.7KB
total			+334.8KB

Unknown metric groups

API count

id	before	after	diff
`securitySolution`	32	1179	+1147
`timelines`	6	877	+871
total			+2018

async chunk count

id	before	after	diff
`timelines`	1	3	+2

References to deprecated APIs

id	before	after	diff
`timelines`	0	28	+28

History

💔 Build #133300 failed 4e4277d
💔 Build #133031 failed 9815b74
💔 Build #132996 failed 05dd22e
💔 Build #132991 failed 95830180a46fc14ae11b90fea18770f9723dd23d
💔 Build #132977 failed a4ddf6f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

watson · 2021-06-23T08:21:37Z

This PR created a new yarn.lock file inside of the x-pack directory. Was this intentional?

* wip * First pass at standalone and embedded redux stores and usage * wip * First pass at standalone and embedded redux stores and usage * wip * clean up * wip * refact(NA): remove extra pkg_npm target and add specific target folders on @kbn/i18n * cleanup * - fixes type errors in tests * WIP remove use_manage_timeline * wip add query + selector * finishing integrating timeline manage context from redux * integrating t-grid in security solution * fix RowRender type * WIP begin to move components from package to plugin * integration of t-grid inside of security solution * wip to make redux work * little trick to make it render * - fixes a few type errors * better integration betwen tgrid and security solutions * bringing back tsconfig on timeline * wip integration t-grid in observability * fix types * fix type in security solutions * add type to import + trie dto get the bundle size as small as possible * fix type in integration test * fix type in integration test * - fix tests * clean up to use technical fields * - fixes unit tests * - mocks the `useDateFormat` function of the `useKibana` service to fix unit tests * fix t-grid settings vs create timeline + fix inspect button * fix last suites test * Update unit tests, snapshots and lint * Fix bad merge * fix plugin export * Fix some failing tests * fix unit tets in timelines plugins * fix latest test * fix i18n * free obs from t-grid * Fix timeline functional plugin types * fix store provider * Update failing defaultHeader test * Fix i18n usage in security solution * Fix remaining i18n errors in timelines plugin * Dedupe common shared types * move drag and drop utils in package to avoid duplication * More shared type cleanup * add feature flag * review I * fix merge with master * fix i18n translation * More type deduping * Use @kbn/common-utils, fix remaining types * fix types * fix tests * missing type * fix cypress tests Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>

XavierM · 2021-06-24T01:01:14Z

This PR created a new yarn.lock file inside of the x-pack directory. Was this intentional?

nope, I will remove it

* wip * First pass at standalone and embedded redux stores and usage * wip * First pass at standalone and embedded redux stores and usage * wip * clean up * wip * refact(NA): remove extra pkg_npm target and add specific target folders on @kbn/i18n * cleanup * - fixes type errors in tests * WIP remove use_manage_timeline * wip add query + selector * finishing integrating timeline manage context from redux * integrating t-grid in security solution * fix RowRender type * WIP begin to move components from package to plugin * integration of t-grid inside of security solution * wip to make redux work * little trick to make it render * - fixes a few type errors * better integration betwen tgrid and security solutions * bringing back tsconfig on timeline * wip integration t-grid in observability * fix types * fix type in security solutions * add type to import + trie dto get the bundle size as small as possible * fix type in integration test * fix type in integration test * - fix tests * clean up to use technical fields * - fixes unit tests * - mocks the `useDateFormat` function of the `useKibana` service to fix unit tests * fix t-grid settings vs create timeline + fix inspect button * fix last suites test * Update unit tests, snapshots and lint * Fix bad merge * fix plugin export * Fix some failing tests * fix unit tets in timelines plugins * fix latest test * fix i18n * free obs from t-grid * Fix timeline functional plugin types * fix store provider * Update failing defaultHeader test * Fix i18n usage in security solution * Fix remaining i18n errors in timelines plugin * Dedupe common shared types * move drag and drop utils in package to avoid duplication * More shared type cleanup * add feature flag * review I * fix merge with master * fix i18n translation * More type deduping * Use @kbn/common-utils, fix remaining types * fix types * fix tests * missing type * fix cypress tests Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co> Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

elasticmachine · 2021-09-22T15:35:44Z

Pinging @elastic/security-solution (Team: SecuritySolution)

XavierM and others added 18 commits May 3, 2021 11:00

wip

a766816

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

4b4226a

First pass at standalone and embedded redux stores and usage

ff8e573

wip

c83fa58

First pass at standalone and embedded redux stores and usage

eb8ac73

wip

129351d

Merge branch 't-grid-new-home' of github.com:XavierM/kibana into t-gr…

cd05741

…id-new-home

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

36c240c

clean up

2bb49a7

wip

e8b0a4b

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

b42b00c

refact(NA): remove extra pkg_npm target and add specific target folde…

fdeaffc

…rs on @kbn/i18n

Merge remote-tracking branch 'upstream/master' into remove-extra-pkg_…

752e357

…npm-from-kbn-i18n

cleanup

c3adc62

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

2f619fc

Merge branch 'remove-extra-pkg_npm-from-kbn-i18n' of github.com:misti…

f047145

…c/kibana into t-grid-new-home

- fixes type errors in tests

df93aa5

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

30bad21

thomasneirynck added the Team:SIEM label May 19, 2021

kqualters-elastic and others added 9 commits May 19, 2021 15:58

WIP remove use_manage_timeline

067bfd1

wip add query + selector

1a9a414

Merge branch 't-grid-new-home' of github.com:XavierM/kibana into t-gr…

6bf50ba

…id-new-home

finishing integrating timeline manage context from redux

83310e3

integrating t-grid in security solution

18ac6db

fix RowRender type

a80802d

WIP begin to move components from package to plugin

8459d5b

Merge branch 't-grid-new-home' of github.com:XavierM/kibana into t-gr…

22016a5

…id-new-home

integration of t-grid inside of security solution

dc7ac7c

wip to make redux work

bee3f65

kqualters-elastic added 2 commits June 21, 2021 10:05

More type deduping

0c53075

Merge remote-tracking branch 'xavier/t-grid-new-home' into t-grid-new…

2a9546d

…-home

mdefazio approved these changes Jun 21, 2021

View reviewed changes

Use @kbn/common-utils, fix remaining types

d1557f3

spalger approved these changes Jun 21, 2021

View reviewed changes

XavierM added 4 commits June 21, 2021 15:28

fix types

2960665

Merge branch 't-grid-new-home' of github.com:XavierM/kibana into t-gr…

0e2286b

…id-new-home

fix tests

8e71b5c

missing type

a4ddf6f

XavierM force-pushed the t-grid-new-home branch 2 times, most recently from aa34392 to 9583018 Compare June 22, 2021 02:52

XavierM enabled auto-merge (squash) June 22, 2021 02:53

fix cypress tests

05dd22e

XavierM force-pushed the t-grid-new-home branch from 9583018 to 05dd22e Compare June 22, 2021 03:58

kqualters-elastic and others added 4 commits June 22, 2021 03:59

Update limits.yml and fix functional plugin tests

9815b74

Merge branch 'master' of github.com:elastic/kibana into t-grid-new-home

fe4be92

fix cypress test + few bugs found

4e4277d

Fix failing jest test

5f43fc4

XavierM merged commit 4fa3dc4 into elastic:master Jun 22, 2021

XavierM mentioned this pull request Jun 23, 2021

[7.x] [RAC] T-Grid is moving to a new home (#100265) #103178

Merged

spalger mentioned this pull request Jun 24, 2021

Update api docs #103310

Merged

tylersmalley mentioned this pull request Jul 26, 2021

[securitySolution] Reduce page load bundle to under 100kB #95870

Open

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 22, 2021

YulNaumenko mentioned this pull request Jan 17, 2022

[RAC] T-Grid home timelines's plugin #99040

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAC] T-Grid is moving to a new home #100265

[RAC] T-Grid is moving to a new home #100265

XavierM commented May 18, 2021 •

edited

Loading

kibanamachine commented May 25, 2021

mdefazio left a comment

spalger left a comment

kibanamachine commented Jun 22, 2021

API count

async chunk count

References to deprecated APIs

watson commented Jun 23, 2021

XavierM commented Jun 24, 2021

elasticmachine commented Sep 22, 2021

[RAC] T-Grid is moving to a new home #100265

[RAC] T-Grid is moving to a new home #100265

Conversation

XavierM commented May 18, 2021 • edited Loading

Summary

Checklist

kibanamachine commented May 25, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

mdefazio left a comment

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 22, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

References to deprecated APIs

History

watson commented Jun 23, 2021

XavierM commented Jun 24, 2021

elasticmachine commented Sep 22, 2021

XavierM commented May 18, 2021 •

edited

Loading