-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api docs #103310
Update api docs #103310
Conversation
As right now, we are having a feature flag and we are not using the timelines UI. Will it be possible to disable the doc on the timelines side for now until the team removed all the duplication? Since merged our direction change to not use the timeline grid but only using the EuiDatagrid for the alerts table. We just need time to get it done. |
If you use the @internal tag, the apis will be stripped from the docs, though I'm guessing adding that to every API would be a lot of work. I could manually delete the file (though I'm not sure exactly which one you would want me to delete), but next time I run this command chances are I'll forget to manually delete it and it'll get merged back in. I'm inclined to just merge as is, unless you are concerned about the amount of data being stored in the repo, @spalger ? |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Security API Integration Tests (Session Idle Timeout).x-pack/test/security_api_integration/tests/session_idle/cleanup·ts.security APIs - Session Idle Session Idle cleanup should not clean up session if user is activeStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XavierM correct me if I'm misunderstanding but it sounds like 300kb of code is being downloaded on each page load and then not used? Why hasn't that PR been reverted? Anyway, this isn't your fault @stacey-gammon LGTM
💔 Backport failed
To backport manually run: |
* Update api docs * update api docs after merge from master # Conflicts: # api_docs/core.json # api_docs/data.json # api_docs/data_index_patterns.json # api_docs/licensing.json # api_docs/saved_objects.json
node scripts/build_api_docs
The diff is so high primarily due to timeline and security solution plugins greatly increasing their public APIs recently