Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kibana.autocomplete config to data plugin #100586

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Migrate kibana.autocomplete config to data plugin #100586

merged 7 commits into from
Jun 1, 2021

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented May 25, 2021 •
edited
Loading

Summary

Resolves #66085.

Migrates the kibana.autocompleteTerminateAfter and kibana.autocompleteTimeout config to the data plugin as data.autocomplete.terminateAfter and data.autocomplete.timeout.

Checklist

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

Release note

The kibana.autocompleteTerminateAfter and kibana.autocompleteTimeout config settings have been renamed as data.autocomplete.valueSuggestions.terminateAfter and data.autocomplete.valueSuggestions.timeout respectively.

@lukasolson lukasolson added review release_note:deprecation v8.0.0 Team:AppServices v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 25, 2021
@lukasolson lukasolson self-assigned this May 25, 2021
@lukasolson lukasolson requested review from a team as code owners May 25, 2021 18:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

pgayvallet
pgayvallet approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once core docs are updated.

@lukasolson lukasolson requested a review from lizozom May 25, 2021 23:07
@lukasolson lukasolson mentioned this pull request May 25, 2021
Merged
5 tasks
crob611
crob611 approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes look good to me.

@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@lukasolson lukasolson force-pushed the migrate-autocomplete-config branch from e924959 to e218549 Compare May 27, 2021 23:40
@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed the code and ran tests on the changes locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 820.8KB 821.4KB +543.0B
inputControlVis 9.8KB 9.7KB -111.0B
total +432.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 256 146 -110
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -340

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit 8edb316 into elastic:master Jun 1, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 1, 2021
@lukasolson @kibanamachine
Migrate kibana.autocomplete config to data plugin (elastic#100586)
9fa507c 
* Migrate kibana.autocomplete config to data plugin

* Fix CI

* Fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jun 1, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 1, 2021
@kibanamachine @lukasolson
Migrate kibana.autocomplete config to data plugin (#100586) (#101088)
d252c4e 
* Migrate kibana.autocomplete config to data plugin

* Fix CI

* Fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 2, 2021
@jloleysens
Merge branch 'reporting/new-png-pdf-report-type' of github.com:jloley…
f34d980 
…sens/kibana into reporting/new-png-pdf-report-type

* 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  [Maps] fix line and polygon label regression (elastic#101085)
  Migrate CCR to new ES JS client. (elastic#100131)
  [Canvas] Switch Canvas to use React Router (elastic#100579)
  [Expressions] Use table column ID instead of name when set (elastic#99724)
  [DOCS] Updates docs landing page (elastic#100749)
  [DOCS] Corrects typo in step 3 (elastic#101079)
  [DOCS] Updates runtime example in Discover (elastic#100926)
  Migrate kibana.autocomplete config to data plugin (elastic#100586)
  [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147)
  [FTR] Use importExport for saved_object/basic archive (elastic#100244)
  [Fleet] Better input for multi text input in agent policy builder (elastic#101020)
  [CI] Buildkite support with Baseline pipeline (elastic#100492)
  [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388)
  Create API keys with metadata (elastic#100682)
  ...
@cjcenizal cjcenizal mentioned this pull request Aug 18, 2021
Closed
KOTungseth added a commit that referenced this pull request Nov 17, 2021
@KOTungseth
[DOCS] Fixes #100586 settings
46255a9
KOTungseth added a commit that referenced this pull request Nov 17, 2021
@KOTungseth
[DOCS] Fixes #100586 settings (#118902)
5fd4c77
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Nov 17, 2021
@KOTungseth
[7.15] [DOCS] Fixes elastic#100586 settings (elastic#118902)
ed2e53d
@KOTungseth KOTungseth mentioned this pull request Nov 17, 2021
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Nov 17, 2021
@KOTungseth
[7.16] [DOCS] Fixes elastic#100586 settings (elastic#118902)
70045d1
@KOTungseth KOTungseth mentioned this pull request Nov 17, 2021
Merged
KOTungseth added a commit that referenced this pull request Nov 19, 2021
@KOTungseth
[7.16] [DOCS] Fixes #100586 settings (#118902) (#118920)
6f8bc77
KOTungseth added a commit that referenced this pull request Nov 19, 2021
@KOTungseth
[7.15] [DOCS] Fixes #100586 settings (#118902) (#118918)
7be8768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@tsullivan tsullivan tsullivan approved these changes

@crob611 crob611 crob611 approved these changes

@lizozom lizozom Awaiting requested review from lizozom

Assignees

@lukasolson lukasolson

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:deprecation review v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breaking] [data.autocomplete] - Migrate core kibana autocomplete configs to data plugin
6 participants
@lukasolson @elasticmachine @kibanamachine @crob611 @tsullivan @pgayvallet