Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updates runtime example in Discover #100926

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented May 28, 2021

Summary

This PR includes additional runtime examples.

Preview:

https://kibana_100926.docs-preview.app.elstc.co/guide/en/kibana/master/discover.html

@gchaps gchaps marked this pull request as ready for review June 1, 2021 17:40
@gchaps gchaps added release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.13.0 v7.14.0 v8.0.0 labels Jun 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested a review from elastic-jb June 1, 2021 17:44
@elastic-jb
Copy link

Content looks good to me. I do have couple questions though. Should this page have some sort of Table of Contents? You need to scroll it all to even know the info is there. Also, is it intentional that it doesn't say runtime fields anywhere?

Copy link

@elastic-jb elastic-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gchaps gchaps merged commit 0d4693c into elastic:master Jun 1, 2021
@gchaps gchaps deleted the docs/update-discover-runtime-fields branch June 1, 2021 20:37
gchaps added a commit to gchaps/kibana that referenced this pull request Jun 1, 2021
* [DOCS] Updates runtime example in Discover

* [DOCS] Updates images

* [DOCS] Adds link to runtime fields
gchaps added a commit to gchaps/kibana that referenced this pull request Jun 1, 2021
* [DOCS] Updates runtime example in Discover

* [DOCS] Updates images

* [DOCS] Adds link to runtime fields
gchaps added a commit that referenced this pull request Jun 1, 2021
* [DOCS] Updates runtime example in Discover

* [DOCS] Updates images

* [DOCS] Adds link to runtime fields
gchaps added a commit that referenced this pull request Jun 1, 2021
* [DOCS] Updates runtime example in Discover

* [DOCS] Updates images

* [DOCS] Adds link to runtime fields
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 2, 2021
…sens/kibana into reporting/new-png-pdf-report-type

* 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  [Maps] fix line and polygon label regression (elastic#101085)
  Migrate CCR to new ES JS client. (elastic#100131)
  [Canvas] Switch Canvas to use React Router (elastic#100579)
  [Expressions] Use table column ID instead of name when set (elastic#99724)
  [DOCS] Updates docs landing page (elastic#100749)
  [DOCS] Corrects typo in step 3 (elastic#101079)
  [DOCS] Updates runtime example in Discover (elastic#100926)
  Migrate kibana.autocomplete config to data plugin (elastic#100586)
  [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147)
  [FTR] Use importExport for saved_object/basic archive (elastic#100244)
  [Fleet] Better input for multi text input in agent policy builder (elastic#101020)
  [CI] Buildkite support with Baseline pipeline (elastic#100492)
  [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388)
  Create API keys with metadata (elastic#100682)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants