-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918
Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918
Changes from 5 commits
7f1a7dd
164582d
7eaf41e
f8e62c6
09589c3
eb75eb0
a930f03
d6f3b09
b82e686
4d05175
75d72ae
e65838b
1fd66af
4560d42
ef9b3b2
b22a032
ddc2280
9d008d8
7bb23dd
65d4c6b
59e4045
4092733
311e3f4
f2a50d3
00d89ca
40cfcce
644a7ac
9bb1b86
12d6e2e
84d9167
4bed458
ecb3135
fe1d8c8
22e7752
96f81a4
e3ae097
06d7c64
2ca4134
17110b1
bc06264
a04e0d7
7fe4e40
2847861
a2e1da8
9263d7d
afff0cc
7cf9172
0a95e55
1a895e5
9ffc3db
4f3c37e
36781db
73a4bfc
ae918cc
e59602c
34f2d86
613e859
676173e
6cdfa84
7b21b7a
103388e
18e75d9
d99d9f8
b121662
42162e3
298ba34
c0fb868
21d173d
b910889
78dfac4
bf583a8
3fd893f
86568ed
952e2a3
e26de43
2d8601b
570cddb
3c7670b
dafb4fe
b7c5ebd
698e8e2
22abf1f
71225eb
f7a816b
2ed0a99
fd39b25
84141fc
e3d3e8c
a193138
eb7fdd7
ce68009
77b5a54
722649e
85e3de7
1c7b613
1f9059c
2085a3b
ccd7e79
66c1d43
018dcb5
34b16c5
fb7e7a9
9f9f936
882d97c
fe20f5c
5345d40
8c2cc61
528c9be
bd694ca
9ba1243
9ef3ab4
5df7d33
315a6e4
02ad6a4
e8c3532
fd54706
8881899
dd62656
acf550b
148623e
7acf83a
dd38b98
b03fa4c
532edae
0af0562
1301303
673e77c
445c846
c08ac43
bee51fd
359df83
bf02730
c0f2105
9266b17
1edb767
373cd68
8f2cb30
6a66a6c
d59dbad
7ef02f4
739fd6f
9d87078
28152b8
e66eb40
5bd080b
56e0f0d
1211f7f
7534f28
6611765
c27aa29
831dedb
511f3f7
58a4ecf
109a5da
66f2645
f93a6ac
edbd419
0f34792
09e9ca0
1014700
4e7fde7
a610aca
1015301
4f55665
8666712
24ee82d
597bcdc
2808f68
7b958ad
6e79546
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -67,7 +67,7 @@ export const ToggleAlertFlyoutButtonComponent: React.FC<Props> = ({ | |||||
> | ||||||
<FormattedMessage | ||||||
id="xpack.uptime.navigateToAlertingButton.content" | ||||||
defaultMessage="Manage alerts" | ||||||
defaultMessage="Manage rules" | ||||||
/> | ||||||
</EuiLink> | ||||||
), | ||||||
|
@@ -114,7 +114,7 @@ export const ToggleAlertFlyoutButtonComponent: React.FC<Props> = ({ | |||||
}, | ||||||
{ | ||||||
id: ALERT_CONTEXT_SELECT_TYPE_PANEL_ID, | ||||||
title: 'create alerts', | ||||||
title: 'Create rules', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should translate this title. We can add the string to the list of translations in the dedicated file, and reference it here.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, I will add that. |
||||||
items: selectionItems, | ||||||
}, | ||||||
]; | ||||||
|
@@ -132,7 +132,7 @@ export const ToggleAlertFlyoutButtonComponent: React.FC<Props> = ({ | |||||
> | ||||||
<FormattedMessage | ||||||
id="xpack.uptime.alerts.toggleAlertFlyoutButtonText" | ||||||
defaultMessage="Alerts" | ||||||
defaultMessage="Alerts and rules" | ||||||
/> | ||||||
</EuiButtonEmpty> | ||||||
} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think potentially you will have remove existing translations from existing translated labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. You might need to manually remove them from the JSON files. Not sure if running
node scripts/i18n_check --fix
will pick this up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thank you, I will try to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node scripts/i18n_check --fix
should fix any removed ids. our extraction tools automatically detect changed messages for retranslation so devs dont ahve to worry about it.