Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918

katrin-freihofner · 2021-05-28T16:27:57Z

Summary

As we updated the terminology around alerts, this is the PR updating our "Alerts" buttons in the headers and the dropdowns they trigger.

Logs

Metrics

APM

Uptime

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…eihofner/kibana into rename-alerts-to-rules

Bamieh

I'm not sure why the kibana-telemetry or the kibana-core team is pinged i dont see any relevant files to the team. localization changes lgtm.

Bamieh · 2021-06-17T14:21:29Z

x-pack/plugins/cases/public/components/case_view/index.tsx

                      getRuleDetailsHref={ruleDetailsNavigation?.href}
                      onRuleDetailsClick={ruleDetailsNavigation?.onClick}
+>>>>>>> master


I believe this git conflict diff is here by mistake 😬

Seems like I missed this one. Thanks for spotting that.

Bamieh · 2021-06-17T14:48:40Z

x-pack/plugins/uptime/public/components/overview/alerts/toggle_alert_flyout_button.tsx

@@ -67,7 +67,7 @@ export const ToggleAlertFlyoutButtonComponent: React.FC<Props> = ({
      >
        <FormattedMessage
          id="xpack.uptime.navigateToAlertingButton.content"
-          defaultMessage="Manage alerts"
+          defaultMessage="Manage rules"


node scripts/i18n_check --fix should fix any removed ids. our extraction tools automatically detect changed messages for retranslation so devs dont ahve to worry about it.

Moved this to a separate issue: #102485

jasonrhodes

LGTM -- we should change the associated method names too so we don't get very confused later but we can do that separately.

stephmilovic

LGTM 📏 📐

justinkambic

A few minor questions - LMK your thoughts.

justinkambic · 2021-06-21T15:09:00Z

x-pack/plugins/uptime/public/components/overview/alerts/toggle_alert_flyout_button.tsx

@@ -114,7 +114,7 @@ export const ToggleAlertFlyoutButtonComponent: React.FC<Props> = ({
      },
      {
        id: ALERT_CONTEXT_SELECT_TYPE_PANEL_ID,
-        title: 'create alerts',
+        title: 'Create rules',


We should translate this title.

We can add the string to the list of translations in the dedicated file, and reference it here.

Suggested change

title: 'Create rules',

title: i18n.translate('xpack.uptime.alerts.createRulesPanel.title', { defaultMessage: 'Create rules' }),

Thank you, I will add that.

justinkambic · 2021-06-21T15:37:54Z

x-pack/plugins/uptime/public/components/overview/monitor_list/columns/translations.ts

@@ -8,11 +8,11 @@
 import { i18n } from '@kbn/i18n';

 export const ENABLE_STATUS_ALERT = i18n.translate('xpack.uptime.monitorList.enableDownAlert', {
-  defaultMessage: 'Enable status alert',
+  defaultMessage: 'Enable rule',


Do we lose some context here? Can we call it Enable status rule or Enable status check rule?

I understand what you mean, I had the same thought but was wondering if it is ok as the column header says Status alert.

shahzad31

Looks good, thanks for doing this.

keeping kibana CI Happy can be a challenge and who doesn't love a designer who can also write code :)

shahzad31 · 2021-06-22T08:45:35Z

@elasticmachine merge upstream

kibanamachine · 2021-06-22T10:49:20Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+2.0B
`infra`	1.7MB	1.7MB	+5.0B
`monitoring`	730.9KB	730.8KB	-5.0B
`observability`	464.5KB	464.5KB	-1.0B
`uptime`	1.1MB	1.1MB	+319.0B
total			+320.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	141.4KB	141.4KB	-2.0B

History

💚 Build #133036 succeeded 7b958ad
💔 Build #132767 failed 2808f68
💚 Build #132350 succeeded 597bcdc
💔 Build #132321 failed 24ee82d
💔 Build #132080 failed 8666712

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…uptime) from alerts to rules (#100918) (#102893) Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>

jonathan-buttner and others added 30 commits March 9, 2021 16:21

Adding feature flag for auth

7f1a7dd

Hiding SOs and adding consumer field

164582d

First pass at adding security changes

7eaf41e

Consumer as the app's plugin ID

f8e62c6

Create addConsumerToSO migration helper

09589c3

Fix mapping's SO consumer

eb75eb0

Add test for CasesActions

a930f03

Declare hidden types on SO client

d6f3b09

Restructure integration tests

b82e686

Init spaces_only integration tests

4d05175

Implementing the cases security string

75d72ae

Merge branch 'master' of github.com:elastic/kibana into cases-rbac-poc

e65838b

Adding security plugin tests for cases

1fd66af

Rough concept for authorization class

4560d42

Adding comments

ef9b3b2

Fix merge

b22a032

Get requiredPrivileges for classes

ddc2280

Check privillages

9d008d8

Ensure that all classes are available

7bb23dd

Success if hasAllRequested is true

65d4c6b

Failure if hasAllRequested is false

59e4045

Adding schema updates for feature plugin

4092733

Seperate basic from trial

311e3f4

Enable SIR on integration tests

f2a50d3

Starting the plumbing for authorization in plugin

00d89ca

Merge branch 'master' into cases-rbac-poc

40cfcce

Unit tests working

644a7ac

Merge branch 'cases-rbac-poc-plugin-changes' into cases-rbac-poc

9bb1b86

Move find route logic to case client

12d6e2e

Create integration test helper functions

84d9167

katrin-freihofner added 2 commits June 17, 2021 13:14

Merge branch 'rename-alerts-to-rules' of https://github.com/katrin-fr…

a610aca

…eihofner/kibana into rename-alerts-to-rules

renamed alerts in Uptime and on the Overview page

1015301

katrin-freihofner requested review from a team as code owners June 17, 2021 12:16

katrin-freihofner requested a review from a team June 17, 2021 12:16

katrin-freihofner added 2 commits June 17, 2021 14:28

resolve conflics

4f55665

resolve conflics

8666712

Bamieh approved these changes Jun 17, 2021

View reviewed changes

azasypkin removed the request for review from a team June 18, 2021 06:05

katrin-freihofner added 2 commits June 18, 2021 08:56

fix tests

24ee82d

fix tests

597bcdc

jasonrhodes approved these changes Jun 18, 2021

View reviewed changes

katrin-freihofner requested a review from shahzad31 June 21, 2021 11:51

stephmilovic approved these changes Jun 21, 2021

View reviewed changes

justinkambic reviewed Jun 21, 2021

View reviewed changes

katrin-freihofner added 2 commits June 21, 2021 18:25

added label to list of translations

2808f68

fix tests

7b958ad

shahzad31 approved these changes Jun 22, 2021

View reviewed changes

Merge branch 'master' into rename-alerts-to-rules

6e79546

katrin-freihofner merged commit 65de579 into elastic:master Jun 22, 2021

katrin-freihofner deleted the rename-alerts-to-rules branch June 22, 2021 11:15

katrin-freihofner mentioned this pull request Jun 22, 2021

[7.x] Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules (#100918) #102893

Merged

lcawl mentioned this pull request Jun 22, 2021

[Monitoring] Update Kibana rules/alerts language in setup mode #102441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918

Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918

katrin-freihofner commented May 28, 2021

Bamieh left a comment

Bamieh Jun 17, 2021

katrin-freihofner Jun 17, 2021

Bamieh Jun 17, 2021

jasonrhodes left a comment

stephmilovic left a comment

justinkambic left a comment

justinkambic Jun 21, 2021

katrin-freihofner Jun 21, 2021

justinkambic Jun 21, 2021

katrin-freihofner Jun 21, 2021

shahzad31 left a comment •

edited

Loading

shahzad31 commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

	title: 'Create rules',
	title: i18n.translate('xpack.uptime.alerts.createRulesPanel.title', { defaultMessage: 'Create rules' }),

Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918

Renamed button and dropdown items in headers (apm, logs, metrics and uptime) from alerts to rules #100918

Conversation

katrin-freihofner commented May 28, 2021

Summary

Logs

Metrics

APM

Uptime

Checklist

For maintainers

Bamieh left a comment

Choose a reason for hiding this comment

Bamieh Jun 17, 2021

Choose a reason for hiding this comment

katrin-freihofner Jun 17, 2021

Choose a reason for hiding this comment

Bamieh Jun 17, 2021

Choose a reason for hiding this comment

jasonrhodes left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

justinkambic Jun 21, 2021

Choose a reason for hiding this comment

katrin-freihofner Jun 21, 2021

Choose a reason for hiding this comment

justinkambic Jun 21, 2021

Choose a reason for hiding this comment

katrin-freihofner Jun 21, 2021

Choose a reason for hiding this comment

shahzad31 left a comment • edited Loading

Choose a reason for hiding this comment

shahzad31 commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

shahzad31 left a comment •

edited

Loading