[Ingest Node Pipelines] Remove default value for error_distance param #102222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
release_note:fix
v8.0.0
Team:Kibana Management
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cuff-links
approved these changes
Jun 16, 2021
…x/ingest_circle_processor
alisonelizabeth
commented
Jun 16, 2021
| @@ -110,14 +104,14 @@ export const Circle: FunctionComponent = () => { | |||
| options: [ | |||
| { | |||
| value: 'shape', | |||
| label: i18n.translate( | |||
| text: i18n.translate( | |||
There was a problem hiding this comment.
The EuiSelect component expects a text prop (docs).
Resolves the warning: Warning: Failed prop type: The prop `options[0].text` is marked as required in `EuiSelect`, but its value is `undefined`.
yuliacech
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Thank you for fixing this, @alisonelizabeth!
Changes LGTM and tested locally 👍
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102147
Release note
The Ingest Node Pipelines UI now requires a user to provide a value for the
error_distanceoption when configuring a circle processor. There is no applicable default value.