CIT for circle processor (renewed PR) #102277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuff-links
changed the title
cuff-links
added
auto-backport
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cuff-links
added
v8.0.0
v7.14.0
release_note:skip
alisonelizabeth
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
This looks great. Thanks @cuff-links! I left one more comment in the code around improving readability and also possibly some missing coverage.
Once your PR is merged, I will update the "required fields" test case in #102222.
..._pipelines/public/application/components/pipeline_editor/__jest__/processors/circle.test.tsx
Show resolved
Hide resolved
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 16, 2021
* Added CITs for Circle processor. * Fixed issue with form function using int instead of string. * Added changed per nits. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 16, 2021
* Added CITs for Circle processor. * Fixed issue with form function using int instead of string. * Added changed per nits. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100106
This PR was also created because of a rebase going wrong with #101871. This PR has all of the commits that were addressed in that PR.
Summary
This PR is to add test coverage for the Ingest Pipelines Circle Processor.
Test cases being covered