Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Add owner and description properties to kibana.json #102707

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[Cases] Add owner and description properties to kibana.json #102707

merged 1 commit into from
Jun 21, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jun 21, 2021 •
edited
Loading

Summary

It has been requested that all Kibana plugins must add the owner and description properties to their kibana.json files.

The json has been formatted to the JSON standard and the keys has been ordered alphabetically.

@cnasikas cnasikas added chore technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 labels Jun 21, 2021
@cnasikas cnasikas self-assigned this Jun 21, 2021
@cnasikas cnasikas requested a review from a team as a code owner June 21, 2021 09:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

stephmilovic
stephmilovic approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You even alphabetized it 😍 Thanks for doing this, LGTM 🚀

@cnasikas cnasikas merged commit 13671c4 into elastic:master Jun 21, 2021
@cnasikas cnasikas deleted the fill_kibana_json branch June 21, 2021 14:38
@cnasikas cnasikas mentioned this pull request Jun 22, 2021
Merged
cnasikas added a commit that referenced this pull request Jun 22, 2021
@cnasikas
[Cases] Add owner and description properties to kibana.json (#102707)…
fe2ef93 
… (#102869)
azasypkin
azasypkin reviewed Aug 4, 2021
View reviewed changes
x-pack/plugins/cases/kibana.json
"kibanaReact",
"kibanaUtils",
"triggersActionsUi"
"configPath":[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnasikas is there any reason why we changed config from xpack.cases to cases.xpack? Noticed that since it broke my 7.13 -> 7.14 upgrade ....

Copy link
Member Author

@cnasikas cnasikas Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azasypkin This is surely a bug. It should not be changed. I will open a PR to fix it for 7.14.1. Sorry for the inconvenience.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell me what kind of configuration you have for cases?

Copy link
Member Author

@cnasikas cnasikas Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #107637. @azasypkin Thanks for cathing that.

Copy link
Member

@azasypkin azasypkin Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell me what kind of configuration you have for cases?

I just disabled it xpack.cases.enabled: false along with a bunch of other plugins in 7.13 🙂

Having said that, in 7.14 cases became a required dependency of the observability, so I re-enabled it anyway. From time to time we recommend customers to disable certain plugins (e.g. if vulnerability is discovered in a plugin and the only way to remediate it before the next patch release is available is to disable it), but it's not something we "advertise" for sure.

Fixed by #107637. @azasypkin Thanks for cathing that.

Awesome 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to cross post the work around here as well just in case someone needs it in the future: cases.xpack.enabled: <true|false> should get kibana running again if you need to specify the option before upgrading 👍

@cnasikas cnasikas mentioned this pull request Aug 4, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner left review comments

@azasypkin azasypkin azasypkin left review comments

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@cnasikas cnasikas

Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cnasikas @elasticmachine @kibanamachine @azasypkin @stephmilovic @michaelolo24 @jonathan-buttner