Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Add owner and description properties to kibana.json #102707

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[Cases] Add owner and description properties to kibana.json #102707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions x-pack/plugins/cases/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
{
"configPath": ["xpack", "cases"],
"id": "cases",
"kibanaVersion": "kibana",
"extraPublicDirs": ["common"],
"requiredPlugins": [
"actions",
"esUiShared",
"features",
"kibanaReact",
"kibanaUtils",
"triggersActionsUi"
"configPath":[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnasikas is there any reason why we changed config from xpack.cases to cases.xpack? Noticed that since it broke my 7.13 -> 7.14 upgrade ....

Copy link
Member Author

@cnasikas cnasikas Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azasypkin This is surely a bug. It should not be changed. I will open a PR to fix it for 7.14.1. Sorry for the inconvenience.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell me what kind of configuration you have for cases?

Copy link
Member Author

@cnasikas cnasikas Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #107637. @azasypkin Thanks for cathing that.

Copy link
Member

@azasypkin azasypkin Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell me what kind of configuration you have for cases?

I just disabled it xpack.cases.enabled: false along with a bunch of other plugins in 7.13 🙂

Having said that, in 7.14 cases became a required dependency of the observability, so I re-enabled it anyway. From time to time we recommend customers to disable certain plugins (e.g. if vulnerability is discovered in a plugin and the only way to remediate it before the next patch release is available is to disable it), but it's not something we "advertise" for sure.

Fixed by #107637. @azasypkin Thanks for cathing that.

Awesome 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to cross post the work around here as well just in case someone needs it in the future: cases.xpack.enabled: <true|false> should get kibana running again if you need to specify the option before upgrading 👍

"cases",
"xpack"
],
"optionalPlugins": ["spaces", "security"],
"server": true,
"ui": true,
"version": "8.0.0"
"description":"The Case management system in Kibana",
"extraPublicDirs":[
"common"
],
"id":"cases",
"kibanaVersion":"kibana",
"optionalPlugins":[
"security",
"spaces"
],
"owner":{
"githubTeam":"security-threat-hunting",
"name":"Security Solution Threat Hunting"
},
"requiredPlugins":[
"actions",
"esUiShared",
"features",
"kibanaReact",
"kibanaUtils",
"triggersActionsUi"
],
"server":true,
"ui":true,
"version":"8.0.0"
}