-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Migrating to kbn_archiver from es_archiver - for the Maps app #103028
[test] Migrating to kbn_archiver from es_archiver - for the Maps app #103028
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-qa (Team:QA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code review only.
@rashmivkulkarni please add a couple of lines in desc to explain what your PR is doing. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change with the filename, after that LGTM.
Please enter the commit message for your changes. Lines starting
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you for migrating the maps tests to kbn_archiver.
code review
💔 Backport failed
To backport manually run: |
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (178 commits) [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028) [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171) [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663) fix too many rernders (elastic#103672) [APM] Add “Analyze Data” button (elastic#103485) [Lens] Fix value popover spacing (elastic#103081) [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926) [SECURITY] Adds security links to doc link service (elastic#102676) Update dependency @elastic/charts to v31 (elastic#102078) [Security Solution][CTI] Investigation time enrichment UI (elastic#103383) Adds ECS guide to doc links service (elastic#102246) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@rashmivkulkarni will have to do the backport manually because .kibana* from 8.0.0 for kbnArchiver doesn't work for 7.x. Removing the labels. Thanks! |
@bhavyarm I removed the 7.14 label too, if you're planning to backport this to 7.14 please make sure to add the 7.15 and 7.14 labels back. Thank you! |
…lastic#103028) * converting Maps es_archiver to kbn_archiver * delete the esArchiver .kibana reference directory * fix the path of the json file * use the delete API to delete the missing references populated in the data.json * fix the path * kbn_archiver_maps.json * added the missing ref * restoring it to use esArchiver * replace esArchiver to use kbnArchiver * moved the data.json directly under kbnArchiver Please enter the commit message for your changes. Lines starting Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional/es_archives/maps/kibana/mappings.json
…103028) (#105838) * converting Maps es_archiver to kbn_archiver * delete the esArchiver .kibana reference directory * fix the path of the json file * use the delete API to delete the missing references populated in the data.json * fix the path * kbn_archiver_maps.json * added the missing ref * restoring it to use esArchiver * replace esArchiver to use kbnArchiver * moved the data.json directly under kbnArchiver Please enter the commit message for your changes. Lines starting Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional/es_archives/maps/kibana/mappings.json
part of #102552
esArchiver
tokbnArchiver
which is a saved object export to handle this data - for all the maps app tests.index.js
for deleting the missing references manually, using the API after successful import.