Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Blank page when navigating to errors metadata #104322

Merged
merged 2 commits into from
Jul 6, 2021
Merged

[APM] Blank page when navigating to errors metadata #104322

merged 2 commits into from
Jul 6, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jul 5, 2021 •
edited
Loading

closes #104160

ezgif com-gif-maker(2)

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 5, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 5, 2021 15:19
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv reviewed Jul 5, 2021
View reviewed changes
x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx
@@ -157,9 +157,9 @@ export function DetailView({ errorGroup, urlParams }: Props) {
<EuiTab
onClick={() => {
history.replace({
...location,
...history.location,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer that we can't catch this bug statically. This issue seems to be exactly that: microsoft/TypeScript#14306

This could be a solution:
microsoft/TypeScript#14306

But it looks like we are already setting no-restricted-globals:

kibana/packages/elastic-eslint-config-kibana/javascript.js

Line 67 in b0b0584

'no-restricted-globals': ['error', ...RESTRICTED_GLOBALS],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqren the rules is only applied for js files https://github.com/elastic/kibana/blob/master/packages/elastic-eslint-config-kibana/javascript.js#L10. I'm going to open a PR that adds this rule in the TS files https://github.com/elastic/kibana/blob/master/packages/elastic-eslint-config-kibana/typescript.js

@sorenlouv
Copy link
Member

Would be great if you can fix this, so it doesn't happen again (aka figure out if we can catch this statically with eslint/typescript)

@cauemarcondes
Copy link
Contributor Author

Would be great if you can fix this, so it doesn't happen again (aka figure out if we can catch this statically with eslint/typescript)

I'm gonna have it fixed on another PR.

@cauemarcondes cauemarcondes merged commit 434568a into elastic:master Jul 6, 2021
@cauemarcondes cauemarcondes deleted the apm-error-metadata branch July 6, 2021 14:04
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@cauemarcondes @kibanamachine
[APM] Blank page when navigating to errors metadata (elastic#104322)
0ab77f3 
* using history.location instead of location

* removing consoles
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@cauemarcondes @kibanamachine
[APM] Blank page when navigating to errors metadata (elastic#104322)
05daef8 
* using history.location instead of location

* removing consoles
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @cauemarcondes
[APM] Blank page when navigating to errors metadata (#104322) (#104464)
015e9ec 
* using history.location instead of location

* removing consoles

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @cauemarcondes
[APM] Blank page when navigating to errors metadata (#104322) (#104463)
05ffc0a 
* using history.location instead of location

* removing consoles

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Blank page when navigating to errors metadata
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv