Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Blank page when navigating to errors metadata #104322

Merged
merged 2 commits into from
Jul 6, 2021
Merged

[APM] Blank page when navigating to errors metadata #104322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eea735
using history.location instead of location
cauemarcondes Jul 5, 2021
0a9d715
removing consoles
cauemarcondes Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,9 @@ export function DetailView({ errorGroup, urlParams }: Props) {
<EuiTab
onClick={() => {
history.replace({
...location,
...history.location,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer that we can't catch this bug statically. This issue seems to be exactly that: microsoft/TypeScript#14306

This could be a solution:
microsoft/TypeScript#14306

But it looks like we are already setting no-restricted-globals:

kibana/packages/elastic-eslint-config-kibana/javascript.js

Line 67 in b0b0584

'no-restricted-globals': ['error', ...RESTRICTED_GLOBALS],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqren the rules is only applied for js files https://github.com/elastic/kibana/blob/master/packages/elastic-eslint-config-kibana/javascript.js#L10. I'm going to open a PR that adds this rule in the TS files https://github.com/elastic/kibana/blob/master/packages/elastic-eslint-config-kibana/typescript.js

search: fromQuery({
...toQuery(location.search),
...toQuery(history.location.search),
detailTab: key,
}),
});
Expand Down