-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alerting][docs] add missing ESS icon for actions setting in doc #107213
Conversation
* Fix upgrade tests for 7.14 * Fix lint issues * Comment out unused const * Update uiSettings for non-default space Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: liza-mae <liza-mae@users.noreply.github.com>
* Add CCS Cypress test runner * Split flow for CCS Cypress tests * Make esArchiver load data onto the remote cluster * Add CCS specific rules with customizable remote name * Allow overriding @kbn/dev-utils's CA_CERT_PATH * Add CCS related docs Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
#105463) * Fix to show better error message * Handle batch errors by still showing as much data as possible * Fix i18n * Fix errors * Fix 404 error, add extractErrorProperties * Fix missing histogram Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
…ver (#103759) (#105474) * [ML] APM latency correlations help popover * Remove spacer * [ML] Updates correlation tooltip * Remove scss, use styled popover instead * Fix order to be Service > Environment > Transaction * Addresses popover text feedback * Addresses more popover text feedback * Adds performance warning to popover; improves tooltip * Internationalizes aria label in popover * Internationalizes aria label in ML popover Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…t synchronisation feature (#105297) (#105468) * [APM] Add telemetry to track usage of the agent config to fleet synchronisation feature (#105297) * removing telemetry hook from pages * adding telemetry to schema and agent config # Conflicts: # x-pack/plugins/apm/server/routes/register_routes/index.ts * fixing merge
* [DOCS] Updates to the Reporting docs (#101326) * [DOCS] Updates to thee Reporting docs * Adds the main sharing page * Final changes * Changed configuring-reporting link to secure-reporting * Updates from meeting with Tim and Larry * Moves reporting and sharing content above ML * Update docs/setup/configuring-reporting.asciidoc Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Review comments from Tim and Larry * Fixes broken links * Fixes redirect * Fixes broken link from ES docs * Adds metadata to changed pages * Review comments Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Fixes ES links * Fixes time-unit ES links Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
* chore(NA): moving @kbn/utils to babel transpiler * chore(NA): changed import paths for that module on kbn-apm-config-loader * fix(NA): import on test file Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
(cherry picked from commit 02fdf6c)
The doc `xpack.actions.customHostSettings[n].ssl.verificationMode` is missing the ess-icon, so this commit adds it.
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this commit adds the icon, but I don't actually see it in the docs preview 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove the icon from xpack.actions.customHostSettings[n].ssl.rejectUnauthorized
? I don't think that was included in the cloud allowlist
Correct, I hadn't added the ability to use
Ya, for some reason the preview doesn't show the icon, but when I run locally, I see it - some weird caching error in the CI? Guess I have one more change to make, let's see if CI does the right thing this time :-) Thanks @ymao1! |
Ah ... the preview doesn't work because the PR is aimed at 7.14 and not master 🤦🏻 . I tried one of the "easy" "edit the doc from GitHub" ui gizmos - won't be trying that again! It also created the branch on the elastic repo, and not mine. Sigh. |
hahahaha ... change base to master => 100's of commits, 1000's of files changed; gonna close this and try again :-) |
closed in favor of: #107481 |
💔 Build Failed
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
The doc
xpack.actions.customHostSettings[n].ssl.verificationMode
is missing the ess-icon, so this commit adds it.doc preview: https://kibana_107213.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html#action-settings