Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerting][docs] add missing ESS icon for actions setting in doc #107213

Closed
wants to merge 10,000 commits into from

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Jul 29, 2021

The doc xpack.actions.customHostSettings[n].ssl.verificationMode is missing the ess-icon, so this commit adds it.

doc preview: https://kibana_107213.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html#action-settings

Spencer and others added 30 commits July 12, 2021 16:29
Co-authored-by: spalger <spalger@users.noreply.github.com>
…onnectors (#105265) (#105346)

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
Co-authored-by: Ece Özalp <ozale272@newschool.edu>
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
…05368)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
…5364)

Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
…105030) (#105373)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Makes some tweaks to the Solution Side nav (and corresponding global nav) due to feedback since merged.
…ess host metadata status toasts on non user initiated errors (#105331) (#105376)
Co-authored-by: Ece Özalp <ozale272@newschool.edu>
* Fix upgrade tests for 7.14

* Fix lint issues

* Comment out unused const

* Update uiSettings for non-default space

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: liza-mae <liza-mae@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
…#105217) (#105391)

* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
…105395)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: Domenico Andreoli <domenico.andreoli@elastic.co>
…ing migration (#105213) (#105415)

* Log a warning when documents of unknown types are detected during migration (#105213)

* Parameterize test for kibana version
* Add CCS Cypress test runner

* Split flow for CCS Cypress tests

* Make esArchiver load data onto the remote cluster

* Add CCS specific rules with customizable remote name

* Allow overriding @kbn/dev-utils's CA_CERT_PATH

* Add CCS related docs

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
…tor.timespan (#104541) (#105425)

* check monitor status by monitor.timespan

* Delete mappings.json

* adjust logic

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
…105437)

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
#105463)

* Fix to show better error message

* Handle batch errors by still showing as much data as possible

* Fix i18n

* Fix errors

* Fix 404 error, add extractErrorProperties

* Fix missing histogram

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
…5470)

* Expire empty sessions after a minute

* Take value from config

Co-authored-by: Liza Katz <lizka.k@gmail.com>
…ver (#103759) (#105474)

* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…t synchronisation feature (#105297) (#105468)

* [APM] Add telemetry to track usage of the agent config to fleet synchronisation feature (#105297)

* removing telemetry hook from pages

* adding telemetry to schema and agent config
# Conflicts:
#	x-pack/plugins/apm/server/routes/register_routes/index.ts

* fixing merge
* [DOCS] Updates to the Reporting docs (#101326)

* [DOCS] Updates to thee Reporting docs

* Adds the main sharing page

* Final changes

* Changed configuring-reporting link to secure-reporting

* Updates from meeting with Tim and Larry

* Moves reporting and sharing content above ML

* Update docs/setup/configuring-reporting.asciidoc

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Review comments from Tim and Larry

* Fixes broken links

* Fixes redirect

* Fixes broken link from ES docs

* Adds metadata to changed pages

* Review comments

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Fixes ES links

* Fixes time-unit ES links

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
…105487)

* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine and others added 7 commits July 28, 2021 22:26
* chore(NA): moving @kbn/utils to babel transpiler

* chore(NA): changed import paths for that module on kbn-apm-config-loader

* fix(NA): import on test file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
…pt (#106997) (#107120)

* [load testing] remove loop and pass simulations seq

* pass string, not array to script

* pass var via export

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
…ful (#106999) (#107137)

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
(cherry picked from commit 02fdf6c)
The doc `xpack.actions.customHostSettings[n].ssl.verificationMode` is missing the ess-icon, so this commit adds it.
@pmuellr pmuellr added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v7.15.0 labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr pmuellr added the release_note:skip Skip the PR/issue when compiling release notes label Jul 29, 2021
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this commit adds the icon, but I don't actually see it in the docs preview 🤔

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the icon from xpack.actions.customHostSettings[n].ssl.rejectUnauthorized? I don't think that was included in the cloud allowlist

@pmuellr
Copy link
Member Author

pmuellr commented Aug 2, 2021

Should we also remove the icon from xpack.actions.customHostSettings[n].ssl.rejectUnauthorized? I don't think that was included in the cloud allowlist

Correct, I hadn't added the ability to use xpack.actions.customHostSettings[n].ssl.rejectUnauthorized in the allow-list code, so I'll remove the cloud icon in the doc for that one. I guess we could add it to the allow-list, but since it's deprecated, and this is a brand new exposed config for cloud, doesn't feel like there's much value in adding it.

I see that this commit adds the icon, but I don't actually see it in the docs preview 🤔

Ya, for some reason the preview doesn't show the icon, but when I run locally, I see it - some weird caching error in the CI? Guess I have one more change to make, let's see if CI does the right thing this time :-)

Thanks @ymao1!

@pmuellr
Copy link
Member Author

pmuellr commented Aug 2, 2021

Ah ... the preview doesn't work because the PR is aimed at 7.14 and not master 🤦🏻 . I tried one of the "easy" "edit the doc from GitHub" ui gizmos - won't be trying that again! It also created the branch on the elastic repo, and not mine. Sigh.

@pmuellr pmuellr changed the base branch from 7.14 to master August 2, 2021 22:43
@pmuellr pmuellr requested review from a team as code owners August 2, 2021 22:43
@pmuellr
Copy link
Member Author

pmuellr commented Aug 2, 2021

hahahaha ... change base to master => 100's of commits, 1000's of files changed;

gonna close this and try again :-)

@pmuellr
Copy link
Member Author

pmuellr commented Aug 2, 2021

closed in favor of: #107481

@pmuellr pmuellr closed this Aug 2, 2021
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [012b6fe]

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr added the backport:skip This commit does not require backporting label Aug 3, 2021
@pmuellr pmuellr deleted the pmuellr/cloud-icon-for-customHostSettings branch August 5, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.