Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] change cloud icon usage for the customHostSettings connector settings #107481

Merged

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Aug 2, 2021

Summary

Adds the cloud icon to xpack.actions.customHostSettings[n].ssl.verificationMode and removes it from xpack.actions.customHostSettings[n].ssl.rejectUnauthorized, in the actions configuration documentation. The doc was written before verificationMode was added and rejectUnauthorized was deprecated.

doc preview: https://kibana_107481.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html#action-settings

pmuellr and others added 2 commits August 2, 2021 18:48
The doc `xpack.actions.customHostSettings[n].ssl.verificationMode` is missing the ess-icon, so this commit adds it.
@pmuellr pmuellr added release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v7.15.0 v7.14.1 labels Aug 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmuellr pmuellr merged commit 76881a2 into elastic:master Aug 3, 2021
@pmuellr pmuellr added the v8.0.0 label Aug 3, 2021
pmuellr added a commit to pmuellr/kibana that referenced this pull request Aug 3, 2021
…r settings (elastic#107481)

Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation.  The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr added a commit to pmuellr/kibana that referenced this pull request Aug 3, 2021
…r settings (elastic#107481)

Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation.  The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr added a commit that referenced this pull request Aug 3, 2021
…r settings (#107481) (#107553)

Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation.  The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr added a commit that referenced this pull request Aug 3, 2021
…r settings (#107481) (#107552)

Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation.  The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
…r settings (elastic#107481)

Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation.  The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported docs Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants