-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[actions] change cloud icon usage for the customHostSettings connector settings #107481
Merged
pmuellr
merged 2 commits into
elastic:master
from
pmuellr:actions/cloud-icon-for-customHostSettings
Aug 3, 2021
Merged
[actions] change cloud icon usage for the customHostSettings connector settings #107481
pmuellr
merged 2 commits into
elastic:master
from
pmuellr:actions/cloud-icon-for-customHostSettings
Aug 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc `xpack.actions.customHostSettings[n].ssl.verificationMode` is missing the ess-icon, so this commit adds it.
pmuellr
added
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Actions
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
docs
v7.15.0
v7.14.1
labels
Aug 2, 2021
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
chrisronline
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Aug 3, 2021
…r settings (elastic#107481) Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation. The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Aug 3, 2021
…r settings (elastic#107481) Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation. The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr
added a commit
that referenced
this pull request
Aug 3, 2021
…r settings (#107481) (#107553) Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation. The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
pmuellr
added a commit
that referenced
this pull request
Aug 3, 2021
…r settings (#107481) (#107552) Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation. The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…r settings (elastic#107481) Adds the cloud icon to `xpack.actions.customHostSettings[n].ssl.verificationMode` and removes it from `xpack.actions.customHostSettings[n].ssl.rejectUnauthorized`, in the actions configuration documentation. The doc was written before `verificationMode` was added and `rejectUnauthorized` was deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
docs
Feature:Actions
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v7.14.1
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the cloud icon to
xpack.actions.customHostSettings[n].ssl.verificationMode
and removes it fromxpack.actions.customHostSettings[n].ssl.rejectUnauthorized
, in the actions configuration documentation. The doc was written beforeverificationMode
was added andrejectUnauthorized
was deprecated.doc preview: https://kibana_107481.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html#action-settings