[Discover] Unskip discover tab field data functional tests #107305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
|
@elasticmachine merge upstream |
…-fields-checking-marks
|
@elasticmachine merge upstream |
…-fields-checking-marks
|
@elasticmachine merge upstream |
…-fields-checking-marks
|
@elasticmachine merge upstream |
…-fields-checking-marks
|
@elasticmachine merge upstream |
kertal
changed the title
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
…-fields-checking-marks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
majagrubic
approved these changes
Aug 19, 2021
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 23, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 23, 2021
kertal
added a commit
that referenced
this pull request
Aug 23, 2021
kertal
added a commit
that referenced
this pull request
Aug 23, 2021
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
clickFieldListItemAddfunction to also check if the field has already been rendered in the document table, something that caused flakiness especially. FurthermoreclickFieldListItemAddwas also used to remove a column from a table, since it was basically toggling the column. Changed this parts of the code to useclickFieldListItemRemove.Fixes #100437
Fixes #103389
Firefox flaky tests run, 100 tries: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1824/
cgroup6 flaky test run 100 tries, 1 unrelated error: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1823/
Checklist