[data.search.aggs] Use fields instead of _source in top_hits agg #109531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into search-handle-warnings
… into search-handle-warnings
… into search-handle-warnings
lukasolson
added
review
Feature:Aggregations
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
@elasticmachine merge upstream |
|
@ppisljar I've tested with |
4 tasks
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2021
…stic#109531) * [data.search] Handle warnings inside of headers * Update docs * Add tests * Remove isWarningResponse * [data.search.aggs] Use fields instead of _source in top_hits agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2021
…stic#109531) * [data.search] Handle warnings inside of headers * Update docs * Add tests * Remove isWarningResponse * [data.search.aggs] Use fields instead of _source in top_hits agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2021
…9531) (#112890) * [data.search] Handle warnings inside of headers * Update docs * Add tests * Remove isWarningResponse * [data.search.aggs] Use fields instead of _source in top_hits agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2021
…9531) (#112891) * [data.search] Handle warnings inside of headers * Update docs * Add tests * Remove isWarningResponse * [data.search.aggs] Use fields instead of _source in top_hits agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 23, 2021
…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (189 commits) fix permissions for cloud test (elastic#112568) Updates the VEGA docs for v8.0 (elastic#112781) Updates the TSVB docs for v8 (elastic#112778) [Expressions] Fix setup and start contracts (elastic#110841) [DOCS] Update remote cluster and security links (elastic#112874) test/functional/apps/management/_test_huge_fields.js (elastic#112878) Fix the other one... (elastic#112873) [data.search.aggs] Use fields instead of _source in top_hits agg (elastic#109531) [Search sessions] Don't show incomplete warning if search requests aren't in session (elastic#112364) [data.search] Do not send ignore_throttled when search:includeFrozen is disabled (elastic#112755) [Monitoring] Add KQL filter bar to alerts (elastic#111663) Log deprecation warnings for plugins which won't be disable-able in 8.0 (elastic#112602) [CI] Balance CI Groups (elastic#112836) Add ILM URLs to documentation link service (elastic#112748) Bump chromedriver to 93 (elastic#112847) [Maps] move joins from LayerDescriptor to VectorLayerDescriptor (elastic#112427) Add a handler for a possible promise rejection (elastic#112840) Removes space, fix build (elastic#112856) [Maps] fix unhandled promise rejections in jest tests (elastic#112712) Copy pass 3 (elastic#112815) ... # Conflicts: # src/plugins/dashboard/public/application/dashboard_app.tsx # src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
lykkin
pushed a commit
to lykkin/kibana
that referenced
this pull request
Sep 28, 2021
…stic#109531) * [data.search] Handle warnings inside of headers * Update docs * Add tests * Remove isWarningResponse * [data.search.aggs] Use fields instead of _source in top_hits agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #103279.
Updates the top_hits agg to use the
fieldsparameter instead of a combination of_sourceanddocvalue_fields.This enables you to use runtime fields in the following:
Things to test:
_sourceChecklist
For maintainers
Release note
Runtime fields can now be used with the "Last value" option in Lens, and with the "Top Hit" metric in aggregation-based visualizations.