Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a handler for a possible promise rejection #112840

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Add a handler for a possible promise rejection #112840

merged 2 commits into from
Sep 22, 2021

Conversation

yakhinvadim
Copy link
Contributor

Summary

This PR fixes the UnhandledPromiseRejectionWarning for the account_settings component. Previosly we were missing catch after the Promise call.

The issue was reported in #112699

Before After
Screen Shot 2021-09-22 at 11 59 05 AM Screen Shot 2021-09-22 at 11 58 12 AM

@yakhinvadim yakhinvadim added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 22, 2021
@yakhinvadim yakhinvadim marked this pull request as ready for review September 22, 2021 15:03
@yakhinvadim yakhinvadim requested a review from a team September 22, 2021 15:03
@yakhinvadim yakhinvadim mentioned this pull request Sep 22, 2021
Closed
23 tasks
@scottybollinger
Copy link
Contributor

Thanks for doing this. When I run this locally, it says there is an uncovered line. Would you mind throwing in a test for that to get coverage?
image

@yakhinvadim
Copy link
Contributor Author

Would you mind throwing in a test for that to get coverage?

Sure, nice catch.

Screen Shot 2021-09-22 at 1 27 28 PM

scottybollinger
scottybollinger approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, Vadim! Thanks for knocking it out so quickly 🎉

@yakhinvadim yakhinvadim enabled auto-merge (squash) September 22, 2021 17:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yakhinvadim yakhinvadim merged commit 11f1c44 into elastic:master Sep 22, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 112840

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 23, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/poc…
8361185 
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (189 commits)
  fix permissions for cloud test (elastic#112568)
  Updates the VEGA docs for v8.0 (elastic#112781)
  Updates the TSVB docs for v8 (elastic#112778)
  [Expressions] Fix setup and start contracts (elastic#110841)
  [DOCS] Update remote cluster and security links (elastic#112874)
  test/functional/apps/management/_test_huge_fields.js (elastic#112878)
  Fix the other one... (elastic#112873)
  [data.search.aggs] Use fields instead of _source in top_hits agg (elastic#109531)
  [Search sessions] Don't show incomplete warning if search requests aren't in session (elastic#112364)
  [data.search] Do not send ignore_throttled when search:includeFrozen is disabled (elastic#112755)
  [Monitoring] Add KQL filter bar to alerts (elastic#111663)
  Log deprecation warnings for plugins which won't be disable-able in 8.0 (elastic#112602)
  [CI] Balance CI Groups (elastic#112836)
  Add ILM URLs to documentation link service (elastic#112748)
  Bump chromedriver to 93 (elastic#112847)
  [Maps] move joins from LayerDescriptor to VectorLayerDescriptor (elastic#112427)
  Add a handler for a possible promise rejection (elastic#112840)
  Removes space, fix build (elastic#112856)
  [Maps] fix unhandled promise rejections in jest tests (elastic#112712)
  Copy pass 3 (elastic#112815)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 24, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 112840 or prevent reminders by adding the backport:skip label.

yakhinvadim added a commit to yakhinvadim/kibana that referenced this pull request Oct 5, 2021
@yakhinvadim
Add a handler for a possible promise rejection (elastic#112840)
c31be52 
* Add a handler for a possible promise rejection

* Improve test coverage
@yakhinvadim yakhinvadim mentioned this pull request Oct 6, 2021
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 6, 2021
yakhinvadim added a commit that referenced this pull request Oct 6, 2021
@yakhinvadim
Add a handler for a possible promise rejection (#112840) (#114037)
e04b2e9 
* Add a handler for a possible promise rejection

* Improve test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottybollinger scottybollinger scottybollinger approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yakhinvadim @scottybollinger @kibanamachine