Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest test suites with unhandled promise rejections #112699

Closed
21 of 23 tasks
jbudz opened this issue Sep 21, 2021 · 8 comments
Closed
21 of 23 tasks

Jest test suites with unhandled promise rejections #112699

jbudz opened this issue Sep 21, 2021 · 8 comments
Labels
blocker impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Operations Team label for Operations Team v7.16.0

Comments

@jbudz
Copy link
Member

jbudz commented Sep 21, 2021

As part of the upgrade to Node 16, unhandled promise rejections now cause the process to exit. The following test suites cause unhandled promise rejections, and need to be fixed before we can proceed with the upgrade:

node scripts/jest <suite>

Update: The following suites have now been skipped

@elastic/kibana-presentation

  • src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.test.tsx
  • src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.test.tsx

@elastic/kibana-stack-management

  • x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts

@elastic/uptime

@elastic/security-solution

  • x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.test.ts
  • x-pack/plugins/security_solution/public/management/pages/policy/view/trusted_apps/layout/policy_trusted_apps_layout.test.tsx

@elastic/kibana-alerting-services


@elastic/kibana-core #112806

  • src/core/server/http/router/socket.test.ts

@elastic/kibana-app-services

  • src/plugins/data/common/search/search_source/search_source.test.ts
  • src/plugins/data/server/search/search_service.test.ts

@elastic/apm-ui #112895

  • x-pack/plugins/apm/public/components/routing/templates/settings_template.test.tsx

@elastic/enterprise-search-frontend #112742, #112840

  • x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_logic.test.ts
  • x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx

@elastic/kibana-gis #112712

  • x-pack/plugins/maps/public/connected_components/edit_layer_panel/edit_layer_panel.test.tsx
  • x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/layer_toc/toc_entry/toc_entry.test.tsx

@elastic/ml-ui #112804

  • x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.test.js
  • x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.test.js
  • x-pack/plugins/ml/server/models/bucket_span_estimator/bucket_span_estimator.test.ts

@elastic/kibana-alerting-services #112703

  • x-pack/plugins/stack_alerts/server/feature.test.ts
  • x-pack/plugins/stack_alerts/server/plugin.test.ts
  • x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.test.tsx
  • x-pack/plugins/triggers_actions_ui/server/data/lib/time_series_query.test.ts

@elastic/security-onboarding-and-lifecycle-mgt

  • x-pack/plugins/security_solution/public/management/components/search_exceptions/search_exceptions.test.tsx
@jbudz jbudz added blocker Team:Operations Team label for Operations Team v7.16.0 labels Sep 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@nreese
Copy link
Contributor

nreese commented Sep 21, 2021

@elastic/kibana-gis tests fixed in #112712

@byronhulcher
Copy link
Contributor

I've fixed the tests for x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_logic.test.ts with #112742 on behalf of @elastic/app-search-frontend.

@elastic/workplace-search-frontend will update when they have addressed the issue in x-pack/plugins/enterprise_search/public/applications/workplace_search/views/account_settings/account_settings.test.tsx

@scottybollinger
Copy link
Contributor

Workplace Search has been completed in #112840

@MiriamAparicio
Copy link
Contributor

APM ui completed in #114233

@sabarasaba
Copy link
Member

Stack management completed in #115362

@tylersmalley
Copy link
Contributor

@jbudz, since the last remaining task is for @elastic/kibana-presentation - mind creating an issue for them and we can close this issue assigned to us out?

@jbudz
Copy link
Member Author

jbudz commented Feb 17, 2022

Moved to #126000. Thanks everyone.

@jbudz jbudz closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Operations Team label for Operations Team v7.16.0
Projects
None yet
Development

No branches or pull requests

8 participants