Fix unhandled promise rejection #114233
Merged
Fix unhandled promise rejection #114233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
release_note:fix
auto-backport
botelastic
bot
added
Team:APM
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
sorenlouv
approved these changes
Oct 7, 2021
MiriamAparicio
force-pushed
the
fix-tests-handle-promise-rejections
branch
from
4a136ee to
06e16e4
Compare
sorenlouv
reviewed
Oct 7, 2021
| setPopoverIsOpen={setIsPopoverOpen} | ||
| onApply={jest.fn()} | ||
| /> | ||
| </IntlProvider> |
There was a problem hiding this comment.
Was this needed to run the apm jest tests?
There was a problem hiding this comment.
It was triggering a warning error
shahzad31
reviewed
Oct 7, 2021
| setPopoverIsOpen={setIsPopoverOpen} | ||
| onApply={jest.fn()} | ||
| /> | ||
| <IntlProvider locale="en"> |
There was a problem hiding this comment.
we can move this wrapper to the render method in '../../utils/test_helper'
shahzad31
approved these changes
Oct 7, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
23 tasks
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2021
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112895
Summary
The test x-pack/plugins/apm/public/components/routing/templates/settings_template.test.tsx contains unhandled promise rejections and causes the process to exit in Node 16 (upgrade pending).
All promise rejections should therefore be handled.
What was done