-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unhandled promise rejection in socket tests #112806
Fix unhandled promise rejection in socket tests #112806
Conversation
Pinging @elastic/kibana-core (Team:Core) |
@@ -92,7 +92,7 @@ describe('KibanaSocket', () => { | |||
}); | |||
const socket = new KibanaSocket(tlsSocket); | |||
|
|||
expect(socket.renegotiate({})).resolves.toBe(result); | |||
await expect(socket.renegotiate({})).rejects.toBe(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we call callback
with a non-null argument in line 90 this promise rejects
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Summary
From #112699
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers