Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip jest handled promise rejections #116021

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Unskip jest handled promise rejections #116021

merged 2 commits into from
Oct 26, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 21, 2021 •
edited
Loading

Part of #112699

@jbudz jbudz added auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Oct 21, 2021
@jbudz
Copy link
Member Author

jbudz commented Oct 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type date "is" operator should filter 1 single date if it is set as an exception

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz marked this pull request as ready for review October 25, 2021 22:10
@jbudz jbudz requested review from a team as code owners October 25, 2021 22:10
@jbudz jbudz enabled auto-merge (squash) October 25, 2021 22:10
sebelga
sebelga approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack management changes LGTM

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

shahzad31
shahzad31 approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@jbudz jbudz merged commit 0b2d3b7 into elastic:master Oct 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.16 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 116021

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 26, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/poc…
446dc6e 
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (347 commits)
  [Upgrade Assistant] Disable UI by default in 8.0 (elastic#115782)
  [Uptime] Added permission for new tls alert (elastic#116107)
  [APM] Optimize synthtrace (elastic#116091)
  Fix ux/apm inspector panel (elastic#116188)
  [RAC]: add experimental badge to alerts (elastic#116090)
  Unskip jest handled promise rejections (elastic#116021)
  [Lens] Improve tick placement for binary formatter (elastic#116158)
  chore: rename getApmHref to getLegacyApmHref (elastic#115689)
  [Security Solution] Validate ipv4/CIDR with format x.x.x.x/xx (elastic#116127)
  [Fleet] Use data stream name in query to get data stream info (elastic#115805)
  [Uptime] TLS and TLS legacy alert translation mismatch (elastic#116113)
  New field for integrations field (elastic#116175)
  Set required to false until the input is not visited (elastic#116099)
  Enable interactive setup by default (elastic#116141)
  Add not ready response to interactive setup (elastic#116138)
  Hide or button if needed (elastic#116124)
  [ML] Adding datafeed api tests (elastic#116133)
  Add page title to index advanced page (elastic#116134)
  chore: rename functions in aggregated_transactions helper  (elastic#116001)
  Fix bug where number rendered as date (elastic#116224)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/lib/screenshots/open_url.ts
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116021 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116021 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116021 or prevent reminders by adding the backport:skip label.

jbudz added a commit to jbudz/kibana that referenced this pull request Nov 1, 2021
@jbudz @kibanamachine
Unskip jest handled promise rejections (elastic#116021)
29e435e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit that referenced this pull request Nov 1, 2021
@jbudz @kibanamachine
Unskip jest handled promise rejections (#116021) (#117000)
44c444e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2021

7.16: 44c444e

@spalger spalger removed the backported label Nov 1, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backported release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbudz @kibanamachine @elasticmachine @sebelga @shahzad31 @spalger