Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] TLS and TLS legacy alert translation mismatch #116113

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Found this while testing #111151

TLS Alert and TLS Alert(Legacy) descriptions were interchanges, fixed that.

After:
image

Before:
image

@shahzad31 shahzad31 requested a review from a team as a code owner October 25, 2021 11:10
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS CI Group #7 / visualize app new charts library visualize ciGroup7 Timelion visualization expression typeahead dynamic suggestions for argument values .es() should show index pattern suggestions for index argument

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uptime 24.9KB 24.9KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Screen Shot 2021-10-25 at 1 04 16 PM

@shahzad31 shahzad31 merged commit 3246018 into elastic:master Oct 26, 2021
@shahzad31 shahzad31 deleted the fix-transaltion-messup branch October 26, 2021 08:29
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 26, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.16
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 26, 2021
…6247)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 26, 2021
…6246)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 26, 2021
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (347 commits)
  [Upgrade Assistant] Disable UI by default in 8.0 (elastic#115782)
  [Uptime] Added permission for new tls alert (elastic#116107)
  [APM] Optimize synthtrace (elastic#116091)
  Fix ux/apm inspector panel (elastic#116188)
  [RAC]: add experimental badge to alerts (elastic#116090)
  Unskip jest handled promise rejections (elastic#116021)
  [Lens] Improve tick placement for binary formatter (elastic#116158)
  chore: rename getApmHref to getLegacyApmHref (elastic#115689)
  [Security Solution] Validate ipv4/CIDR with format x.x.x.x/xx (elastic#116127)
  [Fleet] Use data stream name in query to get data stream info (elastic#115805)
  [Uptime] TLS and TLS legacy alert translation mismatch (elastic#116113)
  New field for integrations field (elastic#116175)
  Set required to false until the input is not visited (elastic#116099)
  Enable interactive setup by default (elastic#116141)
  Add not ready response to interactive setup (elastic#116138)
  Hide or button if needed (elastic#116124)
  [ML] Adding datafeed api tests (elastic#116133)
  Add page title to index advanced page (elastic#116134)
  chore: rename functions in aggregated_transactions helper  (elastic#116001)
  Fix bug where number rendered as date (elastic#116224)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/lib/screenshots/open_url.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.2 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants