-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Added permission for new tls alert #116107
Conversation
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any minors available to backport this to in 7.15?
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works as expected when configuring with a non super user with the permissions to uptime and heartbeat*
.
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (347 commits) [Upgrade Assistant] Disable UI by default in 8.0 (elastic#115782) [Uptime] Added permission for new tls alert (elastic#116107) [APM] Optimize synthtrace (elastic#116091) Fix ux/apm inspector panel (elastic#116188) [RAC]: add experimental badge to alerts (elastic#116090) Unskip jest handled promise rejections (elastic#116021) [Lens] Improve tick placement for binary formatter (elastic#116158) chore: rename getApmHref to getLegacyApmHref (elastic#115689) [Security Solution] Validate ipv4/CIDR with format x.x.x.x/xx (elastic#116127) [Fleet] Use data stream name in query to get data stream info (elastic#115805) [Uptime] TLS and TLS legacy alert translation mismatch (elastic#116113) New field for integrations field (elastic#116175) Set required to false until the input is not visited (elastic#116099) Enable interactive setup by default (elastic#116141) Add not ready response to interactive setup (elastic#116138) Hide or button if needed (elastic#116124) [ML] Adding datafeed api tests (elastic#116133) Add page title to index advanced page (elastic#116134) chore: rename functions in aggregated_transactions helper (elastic#116001) Fix bug where number rendered as date (elastic#116224) ... # Conflicts: # x-pack/plugins/reporting/server/lib/screenshots/observable.ts # x-pack/plugins/reporting/server/lib/screenshots/open_url.ts
Summary
This a follow up to #111151
We added new tls Alert sometimes back, but we didn't declare proper permissions for it.
This PR Fixes that.
Testing
Please follow the instructions from the PR #111180
Basically you need to create a role with heartbeat indices permission.
And then create a user with uptime app and that role present.
Once done, you should be able to see the new TLS Alert in the alerting UI
After:
Before: