Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases][Connectors] ServiceNow ITOM: MVP #114125

Merged
merged 28 commits into from
Oct 19, 2021
Merged

[Cases][Connectors] ServiceNow ITOM: MVP #114125

merged 28 commits into from
Oct 19, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Oct 6, 2021 •
edited by pmuellr
Loading

Summary

Depends on: #105440
Implementation of #114081

doc preview: https://kibana_114125.docs-preview.app.elstc.co/guide/en/kibana/master/action-types.html
then click on "ServiceNow ITOM"

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature v7.16.0 Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:Threat Hunting:Cases labels Oct 6, 2021
@cnasikas cnasikas self-assigned this Oct 6, 2021
@cnasikas cnasikas added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 6, 2021
@cnasikas cnasikas force-pushed the itom_mvp branch 2 times, most recently from 50b5cf3 to 025e0d3 Compare October 8, 2021 13:46
@cnasikas cnasikas marked this pull request as ready for review October 13, 2021 10:57
@cnasikas cnasikas requested review from a team as code owners October 13, 2021 10:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-cases (Feature:Cases)

cnasikas
cnasikas commented Oct 13, 2021
View reviewed changes
x-pack/plugins/actions/README.md
@@ -545,4 +545,4 @@ Instead of `schema.maybe()`, use `schema.nullable()`, which is the same as `sche

## user interface

To make this action usable in the Kibana UI, you will need to provide all the UI editing aspects of the action. The existing action type user interfaces are defined in [`x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types`](../triggers_actions_ui/public/application/components/builtin_action_types). For more information, see the [UI documentation](../triggers_actions_ui/README.md#create-and-register-new-action-type-ui).
To make this action usable in the Kibana UI, you will need to provide all the UI editing aspects of the action. The existing action type user interfaces are defined in [`x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types`](../triggers_actions_ui/public/application/components/builtin_action_types). For more information, see the [UI documentation](../triggers_actions_ui/README.md#create-and-register-new-action-type-ui).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by an automated formating tool. Nothing is changed.

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2021
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Oct 18, 2021
@elastic elastic deleted a comment from kibanamachine Oct 18, 2021
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas closed this Oct 19, 2021
auto-merge was automatically disabled October 19, 2021 11:43

Pull request was closed

@cnasikas cnasikas reopened this Oct 19, 2021
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas enabled auto-merge (squash) October 19, 2021 11:43
@cnasikas cnasikas linked an issue Oct 19, 2021 that may be closed by this pull request
[Connectors] ServiceNow ITOM: MVP #114081
Closed
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2764 2765 +1
triggersActionsUi 379 382 +3
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 317.5KB 303.9KB -13.5KB
triggersActionsUi 789.4KB 814.2KB +24.8KB
total +11.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 80.5KB 80.5KB +30.0B
securitySolution 104.2KB 104.2KB +28.0B
triggersActionsUi 50.8KB 51.8KB +1.0KB
total +1.1KB
Unknown metric groups

async chunk count

id before after diff
cases 15 16 +1
triggersActionsUi 64 66 +2
total +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 20b11c9 into elastic:master Oct 19, 2021
@cnasikas cnasikas deleted the itom_mvp branch October 19, 2021 16:39
@kibanamachine kibanamachine mentioned this pull request Oct 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021
@cnasikas @kibanamachine
[Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125)
f272072 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 19, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
2781812 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (30 commits)
  Fix potential error from undefined (elastic#115562)
  [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542)
  [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125)
  Change default session idle timeout to 8 hours. (elastic#115565)
  Upgrade EUI to v39.1.1 (elastic#114732)
  [App Search] Wired up organic results on Curation Suggestions view (elastic#114717)
  [i18n] remove i18n html extractor (elastic#115004)
  [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103)
  [Transform] Add alerting rules management to Transform UI (elastic#115363)
  Update UI links to Fleet and Agent docs (elastic#115295)
  [ML] Adding ability to change data view in advanced job wizard (elastic#115191)
  Change deleteByNamespace to include legacy URL aliases (elastic#115459)
  [Unified Integrations] Remove and cleanup add data views (elastic#115424)
  [Discover] Show ignored field values (elastic#115040)
  [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524)
  [Discover] Improve doc viewer code in Discover (elastic#114759)
  [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243)
  [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101)
  [Fleet] Add telemetry for integration cards (elastic#115413)
  🐛 Fix single percentile case when ES is returning no buckets (elastic#115214)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
kibanamachine added a commit that referenced this pull request Oct 19, 2021
@kibanamachine @cnasikas
[Cases][Connectors] ServiceNow ITOM: MVP (#114125) (#115599)
12f9c11 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@cnasikas cnasikas

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Cases Cases feature release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Threat Hunting Security Solution Threat Hunting Team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Connectors] ServiceNow ITOM: MVP
5 participants
@cnasikas @elasticmachine @semd @kibanamachine @pmuellr