[Discover] Show ignored field values #115040

timroes · 2021-10-14T15:54:41Z

Summary

This PR adds support for the ignored_field_values API added in elastic/elasticsearch#74121. This allows now seeing values which were ignored e.g. because they were too large or too long in Discover. We track this as a bug fix, since this is how the old _source implementation in Discover worked and was often perceived as a regression bug when switching to the new fields API implementation in Discover. Those values should now show back in Discover (and CSV reporting).

Ignored field values will show a warning now in Discover and filtering will be disabled on them:

Limitations:

ignored values inside nested fields won't be shown by this PR. We decided not to support them by the API, since we don't have the knowledge anymore to know from which "object" inside the nested field the ignored value came, thus we can't reasonably merge them back together.
We decided not to support showing those values if you have a "object column" in your discover table (e.g. object as a column with belows test data). You can't run with the fields API anymore in the situation where you can add object columns, thus we consider them to only be there for backwards compatibility with old saved searches, and won't add this functionality to them.

Content of this PR

Enables merging ignored_field_values in the flattenHit implementation in tabifyDocs (the one that should be used nowadays) behind a parameter. I think the default behavior should stay ignoring these values.
Change the behavior we format whole documents in Discover to use flattenField instead of formatHit (which does not support that parameter yet).
Change Discover logic to no longer use the _source field formatter at all but have all the logic inside it's own plugin. Since there are no further consumers for this "pretty rendered _source" outside Discover, we could simplify the _source field formatter to a simple JSON.stringify (to help get rid of formatHit).
Remove formatHit and formatField completely from DataViews, since Discover and the old _source field formatter were the last consumers of this.
Remove the indexPattern parameter from field formatters, since it was only used by the _source field formatter.

For more details please have a look at my inline comments on this PR and the comments I added to the code.

How to test?

You will require some field values which are ignored either because they are too long or they are malformed. I've used the following commands to get different types of ignore_above ignored data:

Console commands for inserting data

PUT discover-test
{
  "mappings": {
    "properties": {
      "number": {
        "type": "long"
      },
      "text": {
        "type": "keyword"
      },
      "short": {
        "type": "keyword",
        "ignore_above": 8
      },
      "nested": {
        "type": "nested",
        "properties": {
          "short": {
            "type": "keyword",
            "ignore_above": 8
          },
          "more": {
            "type": "keyword"
          }
        }
      },
      "object": {
        "type": "object",
        "properties": {
          "short": {
            "type": "keyword",
            "ignore_above": 8
          },
          "more": {
            "type": "keyword"
          }
        }
      }
    }
  }
}

PUT discover-test/_doc/1?refresh=true
{
  "number": 123,
  "text": "test foo bar",
  "short": ["only", "valid"],
  "nested": [
    { "short": ["only", "valid"], "more": ["some", "more"] },
    { "short": ["too long value"], "more": ["some", "more"] }
  ],
  "object": [
    { "short": ["only", "valid"], "more": ["some", "more"] },
    { "short": ["too long value"], "more": ["some", "more"] }
  ]
}

PUT discover-test/_doc/2?refresh=true
{
  "number": [123],
  "text": ["test foo bar"],
  "short": "valid",
  "nested": { "short": ["too long value"], "more": ["some", "more"] },
  "object": { "short": ["too long value"], "more": ["some", "more"] }
}

PUT discover-test/_doc/3?refresh=true
{
  "number": [],
  "text": [null, null],
  "short": "invalid one",
  "nested": [
    { "short": "this one too long too" },
    { "short": "too long value" }
  ],
  "object": [
    { "short": "this one too long too" },
    { "short": "too long value" }
  ]
}

PUT discover-test/_doc/4?refresh=true
{
  "number": null,
  "text": [""],
  "short": ["mixed", "valid and invalid"],
  "nested": [
    { "short": ["mixed", "with some valid some invalid"], "more": ["some", "more"] },
     { "short": ["mixed", "with some valid some invalid"], "more": ["some", "more"] }
  ],
  "object": [
    { "short": ["mixed", "with some valid some invalid"], "more": ["some", "more"] },
     { "short": ["mixed", "with some valid some invalid"], "more": ["some", "more"] }
  ]
}

PUT discover-test/_doc/5?refresh=true
{
  "short": """[2021-10-14T18:45:33.441+02:00][INFO ][plugins.taskManager] TaskManager is identified by the Kibana UUID: 132a44cb-715c-4b78-9e9a-3a8b56411d4b
[2021-10-14T18:45:33.512+02:00][WARN ][plugins.security.config] Session cookies will be transmitted over insecure connections. This is not recommended.
[2021-10-14T18:45:33.524+02:00][WARN ][plugins.security.config] Session cookies will be transmitted over insecure connections. This is not recommended.
[2021-10-14T18:45:33.567+02:00][INFO ][plugins.ruleRegistry] Write is disabled; not installing common resources shared between all indices
[2021-10-14T18:45:33.835+02:00][INFO ][plugins.reporting.config] Chromium sandbox provides an additional layer of protection, and is supported for Linux Arch Linux Rolling OS. Automatically enabling Chromium sandbox.
[2021-10-14T18:45:33.848+02:00][INFO ][plugins.ruleRegistry] Write is disabled; not installing resources for index .alerts-observability.uptime.alerts
[2021-10-14T18:45:33.848+02:00][INFO ][plugins.ruleRegistry] Write is disabled; not installing resources for index .alerts-observability.logs.alerts
[2021-10-14T18:45:33.848+02:00][INFO ][plugins.ruleRegistry] Write is disabled; not installing resources for index .alerts-observability.metrics.alerts
[2021-10-14T18:45:33.849+02:00][INFO ][plugins.ruleRegistry] Write is disabled; not installing resources for index .alerts-observability.apm.alerts
[2021-10-14T18:45:33.943+02:00][INFO ][savedobjects-service] Waiting until all Elasticsearch nodes are compatible with Kibana before starting saved objects migrations...
[2021-10-14T18:45:33.943+02:00][INFO ][savedobjects-service] Starting saved objects migrations
[2021-10-14T18:45:34.028+02:00][INFO ][savedobjects-service] [.kibana] INIT -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 77ms.
[2021-10-14T18:45:34.029+02:00][INFO ][savedobjects-service] [.kibana_task_manager] INIT -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 77ms.
[2021-10-14T18:45:34.095+02:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 67ms.
[2021-10-14T18:45:34.096+02:00][INFO ][savedobjects-service] [.kibana_task_manager] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 67ms.
[2021-10-14T18:45:34.164+02:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 69ms.
[2021-10-14T18:45:34.169+02:00][INFO ][savedobjects-service] [.kibana_task_manager] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 73ms.
[2021-10-14T18:45:34.253+02:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 89ms.
[2021-10-14T18:45:34.255+02:00][INFO ][savedobjects-service] [.kibana_task_manager] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 86ms.
[2021-10-14T18:45:34.422+02:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 169ms.
[2021-10-14T18:45:34.423+02:00][INFO ][savedobjects-service] [.kibana_task_manager] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 168ms.
[2021-10-14T18:45:34.480+02:00][INFO ][savedobjects-service] [.kibana_task_manager] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE. took: 57ms.
[2021-10-14T18:45:34.480+02:00][INFO ][savedobjects-service] [.kibana_task_manager] Migration completed after 528ms
[2021-10-14T18:45:34.532+02:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE. took: 110ms.
[2021-10-14T18:45:34.533+02:00][INFO ][savedobjects-service] [.kibana] Migration completed after 582ms"""
}

Out of scope

Out of scope of this PR (issues to be created):

Better and longer texts for ignored values (added to Add inline help/documentation to Discover #114271)
Improve disabled filter for ignored values (better help tooltip (currently buttons are just gone) & make it work in data grid)
Improve filter in sidebar for values that are ignored (somehow show a hint beside the filter)
Add better warning icon (via EUI) ([Icon Request] Non searchable field icon eui#5274)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list~~
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…/kibana into dataview/flatten-hit-deprecation

…lues

src/plugins/data/common/search/tabify/tabify_docs.ts

src/plugins/discover/public/application/helpers/get_ignored_reason.ts

ppisljar

░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
░░░░░░░░░░░████░░░░░░░░░░░░░░░░░░░░
░░░░░░░░░███░██░░░░░░░░░░░░░░░░░░░░
░░░░░░░░░██░░░█░░░░░░░░░░░░░░░░░░░░
░░░░░░░░░██░░░██░░░░░░░░░░░░░░░░░░░
░░░░░░░░░░██░░░███░░░░░░░░░░░░░░░░░
░░░░░░░░░░░██░░░░██░░░░░░░░░░░░░░░░
░░░░░░░░░░░██░░░░░███░░░░░░░░░░░░░░
░░░░░░░░░░░░██░░░░░░██░░░░░░░░░░░░░
░░░░░░░███████░░░░░░░██░░░░░░░░░░░░
░░░░█████░░░░░░░░░░░░░░███░██░░░░░░
░░░██░░░░░████░░░░░░░░░░██████░░░░░
░░░██░░████░░███░░░░░░░░░░░░░██░░░░
░░░██░░░░░░░░███░░░░░░░░░░░░░██░░░░
░░░░██████████░███░░░░░░░░░░░██░░░░
░░░░██░░░░░░░░████░░░░░░░░░░░██░░░░
░░░░███████████░░██░░░░░░░░░░██░░░░
░░░░░░██░░░░░░░████░░░░░██████░░░░░
░░░░░░██████████░██░░░░███░██░░░░░░
░░░░░░░░░██░░░░░████░███░░░░░░░░░░░
░░░░░░░░░█████████████░░░░░░░░░░░░░
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░

src/plugins/discover/public/application/apps/main/components/layout/discover_documents.test.tsx

jloleysens

Reporting changes LGTM

ryankeairns · 2021-10-18T14:38:14Z

Tooltips and disabling of filter actions looks good. Noticed an extra 'and' here:

kertal

so far it's looking pretty good, still trying to find the edge case that nobody ever thought of 🔎

src/plugins/discover/public/application/components/table/table_row_btn_filter_add.tsx

src/plugins/discover/public/application/components/table/table_row_btn_filter_remove.tsx

timroes · 2021-10-19T07:44:29Z

@elasticmachine merge upstream

majagrubic · 2021-10-19T08:56:36Z

src/plugins/data/common/search/tabify/tabify_docs.ts

@@ -109,6 +115,28 @@ export function flattenHit(
  flatten(hit.fields || {});
  if (params?.source !== false && hit._source) {
    flatten(hit._source as Record<string, any>);
+  } else if (params?.includeIgnoredValues && hit.ignored_field_values) {
+    // If enabled merge the ignored_field_values into the flattened hit. This will


maybe I am missing something, but shouldn't there be a check if fields are being read from fields API then?

ignored_field_values will only be set if requesting the fields API, and thus we're treating this here the same as the rest of that flatten logic: we ignore the actual request and purely look at the response to flatten, e.g. we also merge fields above ignoring what the request might have been, and simply try to merge it if it's available.

The only case here (as stated by the comment) is, that there might be theoretically _source and fields and ignored_field_values, in which case we don't want to merge the ignored_field_values, since all those values were already in _source and thus we're only doing this logic if we didn't merge _source above.

majagrubic · 2021-10-19T09:06:06Z

src/plugins/data/common/search/tabify/tabify_docs.ts

+    Object.entries(hit.ignored_field_values).forEach(([fieldName, fieldValue]) => {
+      if (flat[fieldName]) {
+        // If there was already a value from the fields API, make sure we're merging both together
+        if (Array.isArray(flat[fieldName])) {


nit: I think this would be more readable if it was all one if-statement:

const valueExists = !!flat[fieldName] if (valueExists && Array.isArray(flat[fieldName])) .... else if (valueExists) ... else ...

I have mixed feelings around that. I feel making the 2nd else basically dependant on the first (in the sense, that the first one is not hit and then recheck half of the condition from the first), imho does not increase readability. We also don't do this in other places, e.g. https://github.com/timroes/kibana/blob/ignored-field-values/src/plugins/discover/public/application/helpers/format_hit.ts#L55-L61 which could also be transformed the same way into:

if (displayKey && fieldsToShow.includes(key)) { pairs.push([displayKey, formattedValue]); } else if (!displayKey) { pairs.push([key, formattedValue]); }

So maybe we can leave that to a democratic vote :)

🚀 - Flatten this out into one dimension as suggested above
🎉 - Keep it in the current nested way

cc @kertal @dmitriynj

"I don't think it would be more readable the way you suggest, Maja, I'd like to keep it as it is" would have been a perfectly fine response

majagrubic · 2021-10-19T09:14:58Z

src/plugins/discover/public/application/apps/main/components/doc_table/components/table_row.tsx

@@ -141,10 +152,9 @@ export const TableRow = ({
    );
  } else {
    columns.forEach(function (column: string) {
-      // when useNewFieldsApi is true, addressing to the fields property is safe
-      if (useNewFieldsApi && !mapping(column) && !row.fields![column]) {
+      if (useNewFieldsApi && !mapping(column) && row.fields && !row.fields[column]) {


afaik, fields API should never not return at least an empty object. maybe worth checking with the ES team to see if this scenario is intentional?

majagrubic · 2021-10-19T09:18:23Z

src/plugins/data/common/search/tabify/tabify_docs.ts

+   * will be merged into the flattened document. This will only have an effect if
+   * the `hit` has been retrieved using the `fields` option.
+   */
+  includeIgnoredValues?: boolean;


Any particular reason we don't make this default to true?

I've talked a bit in the PR description about this. I believe that the behavior of merging a response from the fields API with ignored values together might be more of an edge-case that we need in Discover (where users are more interested "in the document" than in the fields), thus I don't think we should have that on by default. Those values coming from that ignored API might cause other weird side-effects potentially, so I think we should make merging them into the flattened object and opt-in imho.

majagrubic · 2021-10-19T09:21:31Z

src/plugins/discover/public/application/components/table/table_cell_value.tsx

+      case IgnoredReason.MALFORMED:
+        return multiValue
+          ? i18n.translate('discover.docView.table.ignored.multiMalformedTooltip', {
+              defaultMessage: `This field has one or more malformed values that can't be searched or filtered.`,


Nit: for consistency, can this message be "One or more values in this field...", same as for the other two?

cc @gchaps I took your recommendations here, so you might want to give your opinion on this.

Either format works. I went with the text "This field has one or more malformed values that can't be searched or filtered.`" because it is shorter.

src/plugins/discover/public/application/helpers/format_hit.ts

… ignored-field-values

kertal · 2021-10-19T10:34:20Z

src/plugins/discover/public/application/apps/main/components/layout/discover_documents.test.tsx

+jest.mock('../../../../../kibana_services', () => ({
+  ...jest.requireActual('../../../../../kibana_services'),
+  getServices: () => jest.requireActual('../../../../../__mocks__/services').discoverServiceMock,
+}));
+


I think we should refactor the mock to something like getServicesMock, that would also allow you to configure it, if needed ... but not in this PR .. just loud thinking ..

kertal

Code LGTM, tested locally and a-la-carte with Chrome, Safari, Firefox works as expected, didn't manage to break it, great work of simplifying and documenting, and overall restoring behavior of Discover the way it should be! 🥳

dimaanj

LGTM, tested locally in Chrome.

majagrubic

Tested this quite extensively in Chrome on Mac OS X, looks good.

kibanamachine · 2021-10-19T14:21:41Z

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dataViews`	43	42	-1
`discover`	397	400	+3
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2803	2791	-12
`dataViews`	541	526	-15
`fieldFormats`	250	246	-4
total			-31

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`dataViews`	6	5	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	328.9KB	332.2KB	+3.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	465.6KB	465.8KB	+186.0B
`dataViews`	38.8KB	38.0KB	-829.0B
`discover`	22.3KB	22.4KB	+88.0B
`fieldFormats`	49.0KB	48.4KB	-698.0B
total			-1.2KB

Unknown metric groups

API count

id	before	after	diff
`data`	3193	3181	-12
`dataViews`	683	668	-15
`fieldFormats`	288	284	-4
total			-31

References to deprecated APIs

id	before	after	diff
`dataViews`	237	231	-6

History

💔 Build #426 failed 3863d3b
💔 Build #412 failed 5e3974a
💔 Build #410 failed e24d0dd
💚 Build #400 succeeded 79abe37
💔 Build #398 failed 81f2b88
💔 Build #397 failed 0e6ef91

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-10-19T14:46:13Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 115040

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

* WIP replacing indexPattern.flattenHit by tabify * Fix jest tests * Read metaFields from index pattern * Remove old test code * remove unnecessary changes * Remove flattenHitWrapper APIs * Fix imports * Fix missing metaFields * Add all meta fields to allowlist * Improve inline comments * Move flattenHit test to new implementation * Add deprecation comment to implementation * WIP - Show ignored field values * Disable filters in doc_table * remove redundant comments * No, it wasn't * start warning message * Enable ignored values in CSV reports * Add help tooltip * Better styling with warning plus collapsible button * Disable filtering within table for ignored values * Fix jest tests * Fix types in tests * Add more tests and documentation * Remove comment * Move dangerouslySetInnerHTML into helper method * Extract document formatting into common utility * Remove HTML source field formatter * Move formatHit to Discover * Change wording of ignored warning * Add cache for formatted hits * Remove dead type * Fix row_formatter for objects * Improve mobile layout * Fix jest tests * Fix typo * Remove additional span again * Change mock to revert test * Improve tests * More jest tests * Fix typo * Change wording * Remove dead comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/data_views/public/index.ts

Tim Roes and others added 17 commits October 11, 2021 17:35

WIP replacing indexPattern.flattenHit by tabify

9765492

Fix jest tests

76e44ae

Read metaFields from index pattern

4304f55

Remove old test code

13bb111

remove unnecessary changes

07c2231

Remove flattenHitWrapper APIs

983f830

Fix imports

8be2525

Fix missing metaFields

5c47379

Merge branch 'master' into dataview/flatten-hit-deprecation

8292e0c

Add all meta fields to allowlist

6ebbf26

Merge branch 'dataview/flatten-hit-deprecation' of github.com:timroes…

921bd6c

…/kibana into dataview/flatten-hit-deprecation

Merge branch 'master' into dataview/flatten-hit-deprecation

066c7aa

Improve inline comments

5349298

Move flattenHit test to new implementation

911cf9e

Add deprecation comment to implementation

f890df2

Merge branch 'dataview/flatten-hit-deprecation' into ignored-field-va…

ce17147

…lues

WIP - Show ignored field values

4f02850

timroes added Feature:Discover Discover Application release_note:fix v8.0.0 v7.16.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 14, 2021

Tim Roes added 2 commits October 14, 2021 17:55

Disable filters in doc_table

afad073

Merge branch 'master' into ignored-field-values

7829357

timroes added buildkite-ci auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 14, 2021

remove redundant comments

18e2205

timroes commented Oct 14, 2021

View reviewed changes

src/plugins/data/common/search/tabify/tabify_docs.ts Outdated Show resolved Hide resolved

No, it wasn't

71ac26c

timroes commented Oct 14, 2021

View reviewed changes

src/plugins/discover/public/application/helpers/get_ignored_reason.ts Show resolved Hide resolved

kibanamachine and others added 2 commits October 18, 2021 03:16

Merge branch 'master' into ignored-field-values

1802dc7

Change mock to revert test

e24d0dd

ppisljar approved these changes Oct 18, 2021

View reviewed changes

kertal reviewed Oct 18, 2021

View reviewed changes

src/plugins/discover/public/application/apps/main/components/layout/discover_documents.test.tsx Outdated Show resolved Hide resolved

jloleysens approved these changes Oct 18, 2021

View reviewed changes

Tim Roes added 2 commits October 18, 2021 12:20

Improve tests

5e3974a

More jest tests

358b77d

Fix typo

3863d3b

kertal reviewed Oct 18, 2021

View reviewed changes

gchaps reviewed Oct 18, 2021

View reviewed changes

src/plugins/discover/public/application/components/table/table_row_btn_filter_add.tsx Outdated Show resolved Hide resolved

src/plugins/discover/public/application/components/table/table_row_btn_filter_remove.tsx Outdated Show resolved Hide resolved

Change wording

54b03ce

Merge branch 'master' into ignored-field-values

88be299

majagrubic reviewed Oct 19, 2021

View reviewed changes

kertal reviewed Oct 19, 2021

View reviewed changes

src/plugins/discover/public/application/helpers/format_hit.ts Outdated Show resolved Hide resolved

Tim Roes added 2 commits October 19, 2021 11:55

Remove dead comment

267334d

Merge branch 'ignored-field-values' of github.com:timroes/kibana into…

0aa05b1

… ignored-field-values

kertal reviewed Oct 19, 2021

View reviewed changes

kertal approved these changes Oct 19, 2021

View reviewed changes

dimaanj approved these changes Oct 19, 2021

View reviewed changes

majagrubic approved these changes Oct 19, 2021

View reviewed changes

timroes merged commit e8663d4 into elastic:master Oct 19, 2021

timroes deleted the ignored-field-values branch October 19, 2021 14:43

timroes mentioned this pull request Oct 19, 2021

[7.x] [Discover] Show ignored field values (#115040) #115584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Show ignored field values #115040

[Discover] Show ignored field values #115040

timroes commented Oct 14, 2021 •

edited

Loading

ppisljar left a comment •

edited

Loading

jloleysens left a comment

ryankeairns commented Oct 18, 2021

kertal left a comment

timroes commented Oct 19, 2021

majagrubic Oct 19, 2021

timroes Oct 19, 2021

majagrubic Oct 19, 2021

timroes Oct 19, 2021

majagrubic Oct 19, 2021

majagrubic Oct 19, 2021 •

edited

Loading

majagrubic Oct 19, 2021

timroes Oct 19, 2021

majagrubic Oct 19, 2021

timroes Oct 19, 2021

gchaps Oct 19, 2021

kertal Oct 19, 2021

kertal left a comment

dimaanj left a comment

majagrubic left a comment

kibanamachine commented Oct 19, 2021

API count

References to deprecated APIs

kibanamachine commented Oct 19, 2021

[Discover] Show ignored field values #115040

[Discover] Show ignored field values #115040

Conversation

timroes commented Oct 14, 2021 • edited Loading

Summary

Content of this PR

How to test?

Out of scope

Checklist

For maintainers

ppisljar left a comment • edited Loading

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

ryankeairns commented Oct 18, 2021

kertal left a comment

Choose a reason for hiding this comment

timroes commented Oct 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majagrubic Oct 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

dimaanj left a comment

Choose a reason for hiding this comment

majagrubic left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 19, 2021

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Page load bundle

API count

References to deprecated APIs

History

kibanamachine commented Oct 19, 2021

💔 Backport failed

timroes commented Oct 14, 2021 •

edited

Loading

ppisljar left a comment •

edited

Loading

majagrubic Oct 19, 2021 •

edited

Loading