Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Remove deprecation warning for Internal Monitoring #114856

Merged
merged 3 commits into from
Oct 14, 2021
Merged

[Stack Monitoring] Remove deprecation warning for Internal Monitoring #114856

merged 3 commits into from
Oct 14, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 13, 2021

Summary

Closes #111629

Removes this deprecation warning when self-monitoring is enabled:
Screen Shot 2021-10-12 at 3 40 51 PM

To test:

  • Disable monitoring.ui.render_react_app: true in kibana.dev.yml. This warning only shows up in the Angular version.
  • Connect Kibana to a new empty cluster
  • Open Stack Monitoring and enable self-monitoring instead of Metricbeat monitoring
  • Reload the page and ensure no deprecation warning appears

@Zacqary Zacqary added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 13, 2021
@Zacqary Zacqary requested a review from a team as a code owner October 13, 2021 16:32
@Zacqary Zacqary requested review from a team October 13, 2021 16:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 657 656 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1.1MB 1.1MB -3.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

matschaffer
matschaffer approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡 🧡 🧡 for minus-only diff numbers

LGTM. I checked master as well just to make sure this change definitely took effect and it did indeed. Thanks!

@Zacqary Zacqary merged commit 03fe419 into elastic:master Oct 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@Zacqary @kibanamachine
[Stack Monitoring] Remove deprecation warning for Internal Monitoring (…
37fbc31 
…elastic#114856)

* [Stack Monitoring] Remove deprecation warning for Internal Monitoring

* Fix i18n
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
@kibanamachine @Zacqary
[Stack Monitoring] Remove deprecation warning for Internal Monitoring (…
7386cd6 
…#114856) (#115048)

* [Stack Monitoring] Remove deprecation warning for Internal Monitoring

* Fix i18n

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecation warning for internal collection from the stack monitoring UI
3 participants
@Zacqary @kibanamachine @matschaffer