[ML] APM Correlations: Fix percentiles values. #116639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Oct 28, 2021
|
Pinging @elastic/apm-ui (Team:apm) |
|
LGMT 🎉 |
smith
approved these changes
Oct 28, 2021
...apm/server/lib/search_strategies/latency_correlations/latency_correlations_search_service.ts
Outdated
Show resolved
Hide resolved
…ations/latency_correlations_search_service.ts Use raw method instead of callback Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
walterra
added
the
auto-backport
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2021
A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2021
A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg.
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2021
A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2021
A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #114833. Relates to #114734. Fixes #116168.
A change in the ES range agg (elastic/elasticsearch#78344) no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg.
Checklist