Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] APM Correlations: Round duration values to be used in range aggregations. #114833

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[ML] APM Correlations: Round duration values to be used in range aggregations. #114833

merged 2 commits into from
Oct 14, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 13, 2021 •
edited
Loading

Summary

Relates to #114734

A change in the ES range agg (elastic/elasticsearch#78344) no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the values we pass on to the range agg. This will unblock ES snapshot promotion.

Checklist

@walterra walterra self-assigned this Oct 13, 2021
@walterra walterra added bug Fixes for quality problems that affect the customer experience regression release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Oct 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra marked this pull request as ready for review October 14, 2021 08:46
@walterra walterra requested a review from a team as a code owner October 14, 2021 08:46
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

peteharverson
peteharverson approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 14, 2021
@walterra walterra merged commit b0daf93 into elastic:master Oct 14, 2021
@walterra walterra deleted the ml-apm-correlations-fix-range-query branch October 14, 2021 09:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@walterra @kibanamachine
[ML] APM Correlations: Round duration values to be used in range aggr…
f1b1c38 
…egations. (elastic#114833)

A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This fixes the issue by rounding the values we pass on to the range agg.
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
@kibanamachine @walterra
[ML] APM Correlations: Round duration values to be used in range aggr…
24bb845 
…egations. (#114833) (#114962)

A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This fixes the issue by rounding the values we pass on to the range agg.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 14, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting-exa…
3c27f35 
…mple/introduce-baseline-tests

* 'master' of github.com:elastic/kibana: (55 commits)
  [Fleet] Improve Functionality around Managed Package Policies (elastic#114526)
  cleanup (elastic#114902)
  remove stray semicolon (elastic#114969)
  [Security Solution] Edit host isolation exception IP UI (elastic#114279)
  [ML] APM Correlations: Round duration values to be used in range aggregations. (elastic#114833)
  [Index Management] Added `data-test-subj` values to the index context menu buttons (elastic#114900)
  [Stack monitoring] Fix logstash functional tests for react (elastic#114819)
  Implement hybrid approach to writing rule execution event logs (elastic#114852)
  [Detection Rules] Add 7.16 rules (elastic#114939)
  Fixing exceptions export format (elastic#114920)
  Clean up inaccurate comments (elastic#114935)
  chore(NA): fixes a typo on persist_bazel_cache.sh comment (elastic#114943)
  [ci] Fixes Bazel cache writes (elastic#114915)
  fix package.json: (elastic#114936)
  [Controls] Redux Toolkit and Embeddable Redux Wrapper (elastic#114371)
  [APM] Fixes incorrect index config names (elastic#114901) (elastic#114904)
  [Workplace Search] Fix button order and remove extra source name label (elastic#114899)
  [Actions] Fixed actions telemetry for multiple namespaces usage (elastic#114748)
  docs: fix config names (elastic#114903)
  Update kibana to EMS 7.16 (elastic#114865)
  ...
@walterra walterra mentioned this pull request Oct 14, 2021
Closed
@walterra walterra mentioned this pull request Oct 28, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience regression release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @kibanamachine @elasticmachine @dgieselaar @peteharverson