Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management] Added specific data-test-subj values to index context menu buttons #114900

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[Index Management] Added specific data-test-subj values to index context menu buttons #114900

merged 1 commit into from
Oct 14, 2021

Conversation

yuliacech
Copy link
Contributor

Summary

This PR adds specific data-test-subj values to index context menu buttons to make it easier to test index context menu actions. Follow up to @cuff-links tests PR.

@yuliacech yuliacech added Feature:Index Management Index and index templates UI technical debt Improvement of the software architecture and operational architecture v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 13, 2021
@yuliacech yuliacech requested a review from a team as a code owner October 13, 2021 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech yuliacech mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 523.1KB 523.5KB +396.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cuff-links
cuff-links approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and this will help the tests tremendously. Ran locally. Works great. Will merge this change into the existing PRs once merged.

sabarasaba
sabarasaba approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much better! thanks @yuliacech !

@yuliacech yuliacech added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 14, 2021
@yuliacech yuliacech merged commit f2f6bb5 into elastic:master Oct 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@yuliacech @kibanamachine
[Index Management] Added data-test-subj values to the index context…
9678372 
… menu buttons (elastic#114900)
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 14, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting-exa…
3c27f35 
…mple/introduce-baseline-tests

* 'master' of github.com:elastic/kibana: (55 commits)
  [Fleet] Improve Functionality around Managed Package Policies (elastic#114526)
  cleanup (elastic#114902)
  remove stray semicolon (elastic#114969)
  [Security Solution] Edit host isolation exception IP UI (elastic#114279)
  [ML] APM Correlations: Round duration values to be used in range aggregations. (elastic#114833)
  [Index Management] Added `data-test-subj` values to the index context menu buttons (elastic#114900)
  [Stack monitoring] Fix logstash functional tests for react (elastic#114819)
  Implement hybrid approach to writing rule execution event logs (elastic#114852)
  [Detection Rules] Add 7.16 rules (elastic#114939)
  Fixing exceptions export format (elastic#114920)
  Clean up inaccurate comments (elastic#114935)
  chore(NA): fixes a typo on persist_bazel_cache.sh comment (elastic#114943)
  [ci] Fixes Bazel cache writes (elastic#114915)
  fix package.json: (elastic#114936)
  [Controls] Redux Toolkit and Embeddable Redux Wrapper (elastic#114371)
  [APM] Fixes incorrect index config names (elastic#114901) (elastic#114904)
  [Workplace Search] Fix button order and remove extra source name label (elastic#114899)
  [Actions] Fixed actions telemetry for multiple namespaces usage (elastic#114748)
  docs: fix config names (elastic#114903)
  Update kibana to EMS 7.16 (elastic#114865)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 18, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

tylersmalley pushed a commit that referenced this pull request Oct 21, 2021
@kibanamachine @yuliacech
[7.x] [Index Management] Added data-test-subj values to the index c…
9e7cc15 
…ontext menu buttons (#114900) (#114959)

* [Index Management] Added `data-test-subj` values to the index context menu buttons (#114900)

* Fixed test as indices list is different in 7.x

* [Index Management] Fixed indices list test for 7.x

Indices list are different on 7.x and 8.0, that is why the test was failing in the backport branch

* [Index Management] Fixed indices list test for 7.x

Updated the snapshot after the test has been fixed for 7.x

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 21, 2021
@yuliacech yuliacech mentioned this pull request Oct 21, 2021
Merged
@yuliacech yuliacech deleted the index_menu_buttons_tests branch October 25, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuff-links cuff-links cuff-links approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuliacech @elasticmachine @kibanamachine @sabarasaba @cuff-links