[Fleet] Improve Functionality around Managed Package Policies #114526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
kpollich
changed the title
kpollich
commented
Oct 13, 2021
| ({ policy }) => policy?.package_policies as string[] | ||
| ); | ||
| const fulfilledPolicyPackagePolicyIds = fulfilledPolicies | ||
| .filter(({ policy }) => policy?.package_policies) |
There was a problem hiding this comment.
@nchaulet - Here's the fix for that Not Found error we were throwing in tests yesterday
There was a problem hiding this comment.
Great 👍 I am still wondering how this happen in the first place (a default agent policy without package policies)
nchaulet
reviewed
Oct 13, 2021
nchaulet
reviewed
Oct 13, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2021
…c#114526) * Enabled auto policy upgrades for APM and Synthetics * fixup! Enabled auto policy upgrades for APM and Synthetics * Rework preconfiguration policy upgrade flow + report errors * Fix type error in test * Fix type errors + tests * wip * Remove keep policies up to date checks * Remove references to KEEP_POLICIES_UP_TO_DATE_PACKAGES * Move package policy upgrade results to nonFatalErrors * Fix types * Fix type error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 14, 2021
…mple/introduce-baseline-tests * 'master' of github.com:elastic/kibana: (55 commits) [Fleet] Improve Functionality around Managed Package Policies (elastic#114526) cleanup (elastic#114902) remove stray semicolon (elastic#114969) [Security Solution] Edit host isolation exception IP UI (elastic#114279) [ML] APM Correlations: Round duration values to be used in range aggregations. (elastic#114833) [Index Management] Added `data-test-subj` values to the index context menu buttons (elastic#114900) [Stack monitoring] Fix logstash functional tests for react (elastic#114819) Implement hybrid approach to writing rule execution event logs (elastic#114852) [Detection Rules] Add 7.16 rules (elastic#114939) Fixing exceptions export format (elastic#114920) Clean up inaccurate comments (elastic#114935) chore(NA): fixes a typo on persist_bazel_cache.sh comment (elastic#114943) [ci] Fixes Bazel cache writes (elastic#114915) fix package.json: (elastic#114936) [Controls] Redux Toolkit and Embeddable Redux Wrapper (elastic#114371) [APM] Fixes incorrect index config names (elastic#114901) (elastic#114904) [Workplace Search] Fix button order and remove extra source name label (elastic#114899) [Actions] Fixed actions telemetry for multiple namespaces usage (elastic#114748) docs: fix config names (elastic#114903) Update kibana to EMS 7.16 (elastic#114865) ...
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2021
… (#114980) * Enabled auto policy upgrades for APM and Synthetics * fixup! Enabled auto policy upgrades for APM and Synthetics * Rework preconfiguration policy upgrade flow + report errors * Fix type error in test * Fix type errors + tests * wip * Remove keep policies up to date checks * Remove references to KEEP_POLICIES_UP_TO_DATE_PACKAGES * Move package policy upgrade results to nonFatalErrors * Fix types * Fix type error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #114306
This is a repurposed PR that initially handled adding functionality such that APM and Synthetics would automatically have their policies upgraded as part of Fleet's preconfiguration/setup flow. That concept was altered, but there were still some valuable pieces here, namely:
packagePolicyUpgradeResultsvalue returned from setup API callsWe need to perform a dry run before upgrading package policies during setup, because our
packagePolicyService.upgrademethod does not report errors or return a diff in the same manner as our dry run process. By running the dry run first, we can report granular errors and the full upgrade diff in the event of a conflict.