[TSVB] Hides ticks on the y axis for layers with the same format and different template

[alexwizp]

Closes: #123439

Describe the bug:

The bug exists if you have a TSVB timeseries chart with more than 1 layers.

Expected behavior:

• If the formatters are the same (here for example both layers are using percent) and the value template changes we should depict it on the yaxis. We can follow Lens example and display the data with the first template

• If the formatters are different (for example one percent, one default), the y axis should depict the first formatting (as Lens does)

• In TSVB, this was originally implemented differently from LENS. In case the formatters are different, we use the default number formatter

[DianaDerevyankina]

LGTM! Works as expected, tested locally

[alexwizp]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[stratoula]

@elasticmachine merge upstream

[stratoula]

I am testing it by comparing TSVB v7.11 with this branch. One thing that works differently:

• I have 2 layers on the same axis with Bytes formatting. Everything works fine. When I change the template of the first layer to {{value/s}} then the formatting disappears and I see the default formatting.
  

On 7.11 the formatting persists and the template of the first series is applied

[stratoula]

@alexwizp this seems to work as before now.

@flash1293 do you want to also take a look?
When we had discussed it, I thought that TSVB used to work like Lens, if there are 2 layers with different formatting on the same axis, the formatting of the first layer is applied to the axis.

But I checked it on v7.11 and I saw that if you have one layer with percent for example and the second with bytes, no formatter is applied on the yaxis.

I prefer the Lens way but I think that we should be bwc and not change the behavior. Wdyt?

[flash1293]

Good call about not breaking BWC here - it's kind of an edge case though, no strong opinion. I'm happy with the approach in general, there is one thing I noticed though:

This seems to be a separate bug, but if two different formatters (not just different template) are used on two separate axes, the first axis still uses the default formatter:
(count is on the left axis, tooltip is formatted right, but left axis isn't)

it works if the same formatter is used on both (with separate template):

Should we split it out or fix this on this PR?

[stratoula]

@flash1293 yes I know about this too. If you set on the first layer to use a separate left axis, then the formatter is applied....
This is how it worked on 7.11

Screenshot from 7.11 (right axis works fine, left axis doesn't have the format)

With that being said, I think we could create an issue for that and tackle it to a different PR

[flash1293]

Got it, looks good to me in that case.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: c8d581e
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visTypeTimeseries	447.8KB	447.9KB	+74.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[stratoula]

Code LGTM, this works as expected. I created another issue for the behavior that Joe mentions here
#123891

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.0
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation